Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing dns server reference #347

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Conversation

arne21a
Copy link

@arne21a arne21a commented Apr 4, 2022

#346

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • can't test because my setup uses different keys. Logic works with my keys in my setup.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

March platform release deploys two firewalls:
Hub attached firewall connectivity_secure_firewalls_env
VNet attached firewall as a central DNS instance connectivity_private_dns_firewalls_env

This change adds to correct firewall as dns server of the newly created VNet.
See the linked issue

Does this introduce a breaking change

  • YES

  • NO

It will change the current DNS Setting of existing ASVM Subscriptions. In my opinion, this setting is correct.

Testing

Build a level0 to level3 landingzone based on the march release, then use the asvm to create a hub attached subscription.
In my modified scenario, my change worked fine.

Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurentLesle LaurentLesle merged commit af5ccf7 into Azure:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants