Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds azure container registry j2 resource template #369

Merged
merged 4 commits into from
May 25, 2022
Merged

Adds azure container registry j2 resource template #369

merged 4 commits into from
May 25, 2022

Conversation

tschwarz01
Copy link
Contributor

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [ X ] My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • [ X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Adds j2 resource template for azure container registry resource type

Does this introduce a breaking change

  • YES
  • [ X ] NO

Testing

azure_container_registries:
acr1:
name: {{landingzone_definition}}{{env}}acr001
resource_group_key: consumption
sku: Premium
admin_enabled: true
georeplications:
region2:
tags:
region: centralus

LaurentLesle
LaurentLesle requested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tschwarz01 . See my comments and proposed changes

templates/resources/azure_container_registries.tfvars.j2 Outdated Show resolved Hide resolved
templates/resources/azure_container_registries.tfvars.j2 Outdated Show resolved Hide resolved
@LaurentLesle LaurentLesle changed the base branch from main to 2204.1.int May 4, 2022 14:13
@LaurentLesle LaurentLesle changed the base branch from 2204.1.int to main May 4, 2022 14:13
tschwarz01 and others added 2 commits May 4, 2022 09:37
@tschwarz01 @LaurentLesle
Update templates/resources/azure_container_registries.tfvars.j2
594eb3d 
Co-authored-by: lolorol <LaurentLesle@users.noreply.github.com>
@tschwarz01 @LaurentLesle
Update templates/resources/azure_container_registries.tfvars.j2
db5ef22 
Co-authored-by: lolorol <LaurentLesle@users.noreply.github.com>
@arnaudlh arnaudlh added this to the 2205 milestone May 25, 2022
LaurentLesle
LaurentLesle approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@arnaudlh arnaudlh merged commit 4a3cf9f into Azure:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentLesle LaurentLesle LaurentLesle approved these changes

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@tschwarz01 tschwarz01

Labels
5.5.9
Projects
None yet
Milestone
2205
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tschwarz01 @LaurentLesle @arnaudlh