Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vnet_peerings_v1 - Better support vnet peerings between subscriptions #370

Merged
merged 1 commit into from
May 25, 2022
Merged

Add vnet_peerings_v1 - Better support vnet peerings between subscriptions #370

merged 1 commit into from
May 25, 2022

Conversation

LaurentLesle
Copy link
Contributor

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

aztfmod/examples/networking/virtual_network/103-vnet-peering-v1

@LaurentLesle LaurentLesle added the enhancement New feature or request label May 4, 2022
@arnaudlh arnaudlh added this to the 2205 milestone May 25, 2022
@arnaudlh arnaudlh self-requested a review May 25, 2022 12:10
arnaudlh
arnaudlh approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit 33d2e2b into main May 25, 2022
@arnaudlh arnaudlh deleted the vnet-peering-cross-sub branch May 25, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@LaurentLesle LaurentLesle

Labels
5.5.9 enhancement New feature or request
Projects
None yet
Milestone
2205
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LaurentLesle @arnaudlh