Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for packer_build module #382

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Add support for packer_build module #382

merged 1 commit into from
Jun 22, 2022

Conversation

dimitrifc
Copy link

Add support for packer build module

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Add packer_build variable to use the packer_build module added to terraform-azurerm-caf

Does this introduce a breaking change

  • YES
  • NO

Testing

arnaudlh
arnaudlh approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added the enhancement New feature or request label Jun 17, 2022
@arnaudlh arnaudlh added this to the 2206 milestone Jun 17, 2022
@arnaudlh arnaudlh added the 5.6.0 label Jun 22, 2022
@arnaudlh arnaudlh changed the base branch from main to int-5.6.0 June 22, 2022 03:04
@arnaudlh arnaudlh merged commit 7a9f02c into Azure:int-5.6.0 Jun 22, 2022
@arnaudlh
Copy link
Member

Thanks for your contribution to CAF @dimitrifc!

@joeybdub
Copy link

joeybdub commented Feb 2, 2023 •
edited

When will this be in main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@dimitrifc dimitrifc

Labels
5.6.0 enhancement New feature or request
Projects
None yet
Milestone
2206
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimitrifc @arnaudlh @joeybdub