Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variables for cosmos db custom roles #431

Merged
merged 1 commit into from
May 24, 2023
Merged

Add variables for cosmos db custom roles #431

merged 1 commit into from
May 24, 2023

Conversation

brk3
Copy link
Contributor

@brk3 brk3 commented Nov 7, 2022 •
edited

Requires aztfmod/terraform-azurerm-caf#1418

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@brk3 brk3 force-pushed the pbourke/cosmosdb-custom-roles branch from d18534b to e45b4ee Compare November 7, 2022 18:35
@brk3 brk3 changed the title Pbourke/cosmosdb custom roles Add variables for cosmos db custom roles Nov 7, 2022
@brk3 brk3 mentioned this pull request Nov 8, 2022
Merged
@gaoyarui
Copy link

gaoyarui commented Dec 5, 2022

liscenne

@arnaudlh arnaudlh self-requested a review March 22, 2023 10:55
@LaurentLesle LaurentLesle changed the base branch from main to int-5.7.0 May 4, 2023 11:56
LaurentLesle
LaurentLesle approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LaurentLesle
LaurentLesle approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurentLesle LaurentLesle merged commit c937b35 into Azure:int-5.7.0 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentLesle LaurentLesle LaurentLesle approved these changes

@arnaudlh arnaudlh Awaiting requested review from arnaudlh

Assignees

@brk3 brk3

Labels
pending module update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brk3 @gaoyarui @LaurentLesle @arnaudlh