-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added dynamic_keyvault_certificates to caf_solution #449
Open
nusrath432
wants to merge
1
commit into
Azure:main
Choose a base branch
from
nusrath432:nm-m-dynamic-keyvault-certificates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
module "dynamic_keyvault_certificates" { | ||
# source = "aztfmod/caf/azurerm//modules/security/dynamic_keyvault_certificates" | ||
# version = "5.6.5" | ||
|
||
source = "git::https://github.com/aztfmod/terraform-azurerm-caf.git//modules/security/dynamic_keyvault_certificates?ref=main" | ||
|
||
for_each = { | ||
for keyvault_key, certificates in try(var.dynamic_keyvault_certificates, {}) : keyvault_key => { | ||
for key, value in certificates : key => value | ||
if try(value.value, null) == null | ||
} | ||
} | ||
|
||
settings = each.value | ||
keyvault = module.solution.keyvaults[each.key] | ||
objects = module.solution | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you add the module "dynamic_keyvault_certificates" in the caf solution?
I would assume it can be be handled in the aztfmod module directly.
The only reason we put the dynamic_keyvault_secrets into caf_solution is to prevent circular references and to be able to include in a secret value any output attribute of the aztfmod module. Looks like it is not required for the certificates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LaurentLesle I was just following the pattern. If not here, can you identify the location within the modules where this should be implemented, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason dynamic secrets was done that way was to have the option to inject as a keyvault secret's value any output object's attribute from the aztfmod module. Based on my deeper review of your PR is looks like it is only the outcome of the self_signed cert that you may want to add as a certificate value. In that case it can be handled within the module and terraform will deal with the dependencies.
Either you propose an update or I can submit a PR and share it with you for review