Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: a new addon to support aks private cluster usecases #458

Merged
merged 19 commits into from
May 11, 2023

Conversation

najvv
Copy link
Contributor

@najvv najvv commented Apr 13, 2023

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

AKS addon with exec plugin authentication. Provide some necessary tools to perform cluster configuration.

Does this introduce a breaking change

  • YES
  • NO

Testing

example files are provided

@najvv
Copy link
Contributor Author

najvv commented Apr 17, 2023

@microsoft-github-policy-service agree

Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good PR. Can you also add one folder with an example we can add in the ci to test all the components

@najvv
Copy link
Contributor Author

najvv commented May 9, 2023

@LaurentLesle thank you for the feedback. I have added an example set. let me know if you want me to add aks cluster config in aztfmod repo.

1 similar comment
@najvv
Copy link
Contributor Author

najvv commented May 9, 2023

@LaurentLesle thank you for the feedback. I have added an example set. let me know if you want me to add aks cluster config in aztfmod repo.

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit 5b06fb9 into Azure:main May 11, 2023
1 of 2 checks passed
@arnaudlh
Copy link
Member

thanks for your contribution @najvv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants