Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch lb resources #477

Closed
wants to merge 2 commits into from
Closed

Conversation

jvdhaterd
Copy link

Issue-id

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Added the missing lb resources to the local.networking.tf and variables.networking.tf

Does this introduce a breaking change

  • YES
  • NO

Testing

- lb_nat_pool
- lb_nat_rule                
- lb_outbound_rule 
- lb_probe                                      
- lb_rule
- lb_nat_pool
- lb_nat_rule 
- lb_outbound_rule
- lb_probe
- lb_rule
@jvdhaterd
Copy link
Author

@microsoft-github-policy-service agree

@arnaudlh
Copy link
Member

Thanks for your PR @jvdhaterd! I will close this one as the networking was updated already in #476! Keep up the good contributions!

@arnaudlh arnaudlh closed this Jun 20, 2023
@jvdhaterd jvdhaterd deleted the patch-lb-resources branch June 20, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants