Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aks_applications_v2 should work without AKS keyvault secret provider … #484

Merged

Conversation

florentvaldelievre
Copy link

Description

This plugin only works if key_vault_secrets_provider AKS addon is installed. It should be optional.

Does this introduce a breaking change

  • YES
  • [ x] NO

@arnaudlh arnaudlh self-requested a review July 24, 2023 08:39
@arnaudlh arnaudlh added the bug Something isn't working label Jul 24, 2023
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit 8e04113 into Azure:main Aug 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants