Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update landingzone.tf - changed var.logic_app to local.logic_app #489

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Update landingzone.tf - changed var.logic_app to local.logic_app #489

merged 1 commit into from
Aug 4, 2023

Conversation

chianw
Copy link
Contributor

@chianw chianw commented Aug 4, 2023

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • [x ] I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The landingzone.tf file in caf_solution is incorrectly using var.logic_app when it should be using local.logic_app , and this causes only resource groups to be created when following https://github.com/aztfmod/terraform-azurerm-caf/blob/int-5.7.0/examples/logic_app/104-logic_app_action_custom/configuration.tfvars example

Does this introduce a breaking change

  • YES
  • [x ] NO

Testing

arnaudlh
arnaudlh approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added bug Something isn't working launchpad_opensource_light Items related to launchpad_opensource_light logic_app and removed launchpad_opensource_light Items related to launchpad_opensource_light labels Aug 4, 2023
@arnaudlh arnaudlh added this to the 5.7.2 milestone Aug 4, 2023
@arnaudlh
Copy link
Member

arnaudlh commented Aug 4, 2023

good catch, thanks @chianw for the PR

@arnaudlh arnaudlh merged commit 7481dc1 into Azure:int-5.7.0 Aug 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@chianw chianw

Labels
bug Something isn't working logic_app
Projects
None yet
Milestone
5.7.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chianw @arnaudlh