Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslz to 4.2.0 and fix minor issues #491

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Update eslz to 4.2.0 and fix minor issues #491

merged 1 commit into from
Sep 21, 2023

Conversation

heintonny
Copy link
Contributor

Issue-id

PR Checklist

Update add-on eslz to 4.2.0, tested with my dev tenant and lz configuration. Fix minor issues with sourcing subscription_id and alligned hashicorp/azurerm provider version with caf_colution (3.54)

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

LaurentLesle
LaurentLesle approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added the enhancement New feature or request label Sep 21, 2023
@arnaudlh arnaudlh merged commit 56d6bad into Azure:main Sep 21, 2023
1 check passed
@arnaudlh
Copy link
Member

thanks for your PR @heintonny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentLesle LaurentLesle LaurentLesle approved these changes

Assignees

@heintonny heintonny

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heintonny @arnaudlh @LaurentLesle