Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/flag rooms support #851

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Feature/flag rooms support #851

wants to merge 23 commits into from

Conversation

ahammer
Copy link
Member

@ahammer ahammer commented Apr 18, 2024

Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Pull request checklist

This PR has considered:

  • Color Theming
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • View Data Injection
  • Demo App UI/UX update

How to Test

  • Open...
  • Click on...

What to Check

Before After
Screenshot or description before this change Screenshot or description with this change

Other Information

ShaunaSong and others added 17 commits March 2, 2024 06:35
@ShaunaSong
[Calling][Bug] Visual label and accessible name are not similar for c…
03aa972 
…ontrol. (#814)
@pavelprystinka
[Release] Merge AzureCommunicationUICalling 1.6.0 (#816)
cd33551
@ShaunaSong
[Calling][Refactor] Update the support version (#844) (#845)
dcb62e5
@ShaunaSong
[Calling][Release]Update the release version (#843)
cc6c741
@ShaunaSong
Merge branch 'main' into refactor/fix-main-conflict
b76e0a5
@ShaunaSong
Remove the duplicate code
8b46d3e
@ShaunaSong
[Calling][Refactor] Fix the Release to Main Conflicts
4d7bf66
@ShaunaSong
[Release] Merge AzureCommunicationUICalling 1.6.1
87b28d6
@ahammer
some disabled flagging for rooms (will re-enable with tool)
b4eec0e
@ahammer
Parsing of disabled fixed up (some mismatches/errors)
2608bca
@ahammer
more disabling
b2ad2d9
@ahammer
finished disabled pass of flagged rooms
4f2ee87
@ahammer
build succeeded
2c459b5
@ahammer
Fixed up some flags that didn't parse
3629553
@ahammer
Re-enable and set scope to beta
6bd1be4
@ahammer
Fixed one build error in enabled state
02650e2
@ahammer
Merge branch 'main' into feature/flag_rooms_support
7e10dfc
@ahammer ahammer marked this pull request as ready for review April 19, 2024 19:25
@ahammer ahammer requested review from a team as code owners April 19, 2024 19:25
@ahammer ahammer changed the base branch from main to develop April 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelprystinka pavelprystinka Awaiting requested review from pavelprystinka pavelprystinka is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-1

@jamchengms jamchengms Awaiting requested review from jamchengms jamchengms is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-1

@iaulakh iaulakh Awaiting requested review from iaulakh iaulakh is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-1

@ShaunaSong ShaunaSong Awaiting requested review from ShaunaSong ShaunaSong is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-2

@Mohtasim Mohtasim Awaiting requested review from Mohtasim Mohtasim is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-2

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-2

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-mobile-chat-reviewer-2

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahammer @ShaunaSong @pavelprystinka