Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OIDC for triggering npm publishing pipelines #4649

Merged
merged 10 commits into from
May 23, 2024
Merged

Use OIDC for triggering npm publishing pipelines #4649

merged 10 commits into from
May 23, 2024

Conversation

JamesBurnside
Copy link
Member

What

  • Update to use existing az login for triggering npm publishing pipelines
    • Generate an access token as the PAT as the Azure/pipelines action does not natively support OIDC login
  • In the backend we have updated the registration to have access to the publishing pipeline

Why

No more PAT! 🎉

How Tested

Ran successful alpha release: https://github.com/Azure/communication-ui-library/actions/runs/9201207206

@JamesBurnside JamesBurnside requested a review from a team as a code owner May 23, 2024 02:40
@JamesBurnside JamesBurnside requested review from a team as code owners May 23, 2024 02:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited

CallWithChat bundle size is not changed.

  • Current size: 6171038
  • Base size: 6171038
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited

Chat bundle size is not changed.

  • Current size: 2057173
  • Base size: 2057173
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited

Calling bundle size is not changed.

  • Current size: 4846447
  • Base size: 4846447
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25778 / 40006
64.43%		 25778 / 40006
64.43%		 710 / 1255
56.57%		 2063 / 3249
63.49%
Current 25836 / 40006
64.58%		 25836 / 40006
64.58%		 710 / 1255
56.57%		 2076 / 3263
63.62%
Diff 58 / 0
0.15%		 58 / 0
0.15%		 0 / 0
0%		 13 / 14
0.13%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50207 / 80236
62.57%		 50207 / 80236
62.57%		 1028 / 2278
45.12%		 2932 / 4811
60.94%
Current 50268 / 80236
62.65%		 50268 / 80236
62.65%		 1028 / 2278
45.12%		 2974 / 4835
61.5%
Diff 61 / 0
0.08%		 61 / 0
0.08%		 0 / 0
0%		 42 / 24
0.56%

@JamesBurnside JamesBurnside merged commit a362e29 into main May 23, 2024
40 checks passed
@JamesBurnside JamesBurnside deleted the jaburnsi/remove-pat-usage-in-npm-release branch May 23, 2024 18:38
JamesBurnside added a commit that referenced this pull request May 23, 2024
@JamesBurnside
Use OIDC for triggering npm publishing pipelines (#4649)
5c68bd1
@JamesBurnside JamesBurnside mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkwa-msft alkwa-msft alkwa-msft approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@emlynmac emlynmac

@palatter palatter

@carocao-msft carocao-msft

@edwardlee-msft edwardlee-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JamesBurnside @alkwa-msft @dmceachernmsft @emlynmac @palatter @carocao-msft @edwardlee-msft