Add api extractor #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesBurnside
commented
Mar 12, 2021
JamesBurnside
requested review from
alkwa-msft,
allenplusplus,
anjulgarg,
mgamis-msft,
PorterNan and
ytyeason
as code owners
alkwa-msft
reviewed
Mar 15, 2021
| @@ -54,7 +54,7 @@ export const isInCall = (callState: CallState): boolean => !!(callState !== 'Non | |||
| /** | |||
| * Check if a given string is a GUID. | |||
| * Regex expression from: https://stackoverflow.com/a/13653180 | |||
| * @param s string to check | |||
| * @param s - string to check | |||
| */ | |||
| export const isGUID = (s: string): boolean => | |||
There was a problem hiding this comment.
since this is just used for groupId? should we rename s to groupId?
I don't know if calling this "s" is a good idea
There was a problem hiding this comment.
the function itself is agnostic to whether its a groupId, it just checks if any string is a guid. I could rename to str or stringToCheck?
alkwa-msft
approved these changes
Mar 15, 2021
JamesBurnside
commented
Mar 15, 2021
JamesBurnside
commented
Mar 15, 2021
anjulgarg
approved these changes
Mar 15, 2021
DominikMe
approved these changes
Mar 15, 2021
packages/acs-calling-declarative/etc/acs-calling-declarative.api.md
Outdated
Show resolved
Hide resolved
…cation-ui-sdk into jaburnsi/add-api-extractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add api-extractor
Why
Future option
Once we hit release we could use the api extractor to block checks in any breaking change was made (doesn't support this natively but should be very implementable)
How Tested
View change failing CI: https://github.com/Azure/communication-ui-sdk/pull/68/checks?check_run_id=2114177689