Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datatables issue and indicator not loading for Table API > Entities. Upgrade jquery. Fix right panel resize issue. #1713

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

languy
Copy link
Member

@languy languy commented Dec 15, 2023

Preview this branch

  • Fix the issue that prevents displaying entities below by upgrading the datatables packages to latest
  • Upgrade jquery
  • Fix 404 when loading LoadingIndicator_3Squares.gif
  • Fix resizing issue of the right panel.
image

This patches the datatable.net-colreorder package because of the error below.
image
There is a postinstall script that automatically patches the offending types.d.ts file after install.
If you have trouble compiling, because the file wasn't patched, remove the module and reinstall.
rm -rf node_modules/datatable.net-colreorder
npm i

@languy languy requested a review from a team as a code owner December 15, 2023 10:30
@languy languy changed the title Fix datatables issue and indicator not loading for Table API > Entities. Upgrade jquery Fix datatables issue and indicator not loading for Table API > Entities. Upgrade jquery. Fix right panel resize issue. Dec 18, 2023
vchske
vchske previously approved these changes Dec 19, 2023
src/Explorer/Tables/DataTable/DataTableOperations.ts Outdated Show resolved Hide resolved
@languy languy merged commit e9181f1 into master Jan 3, 2024
18 checks passed
@languy languy deleted the users/languy/fix-datatable branch January 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants