Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dab validate fetch schema from url error #2013

Closed
seantleonard opened this issue Feb 6, 2024 · 2 comments · Fixed by #2099
Closed

dab validate fetch schema from url error #2013

seantleonard opened this issue Feb 6, 2024 · 2 comments · Fixed by #2099
Assignees
@abhishekkumams
Labels
bug Something isn't working
Milestone
0.12rc

Comments

@seantleonard
Copy link
Contributor

URL referenced json schemas fail to resolve when using dab validate

Originally posted by @Aniruddh25 in #2011 (comment)
@seantleonard seantleonard mentioned this issue Feb 6, 2024
Merged
@seantleonard seantleonard added this to the 0.12rc milestone Feb 6, 2024
@abhishekkumams abhishekkumams added the bug Something isn't working label Feb 7, 2024
@Aniruddh25
Copy link
Contributor

Faced this issue in 0.11.6-rc too.

@seantleonard
Copy link
Contributor Author

Dependent on #2037

@abhishekkumams abhishekkumams mentioned this issue Mar 13, 2024
Merged
2 tasks
seantleonard pushed a commit that referenced this issue Mar 25, 2024
@abhishekkumams
Fix dab validate schema fetch Error from URL (#2099)
8c95d76 
## Why make this change?

- Closes #2013
- An error is thrown when NJsonSchema tries to fetch the schema from
url, due to failing to add refrences.

## What is this change?

- since, we only need to fetch the data from the schema file, we can
simply make a get call to the url, instead of using NJsonSchema.

## How was this tested?

- [ ] Integration Tests
- [ ] Unit Tests

## Sample Request(s)

- Example REST and/or GraphQL request to demonstrate modifications
- Example of CLI usage to demonstrate modifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhishekkumams abhishekkumams

Labels
bug Something isn't working
Projects
None yet
Milestone
0.12rc
Development

Successfully merging a pull request may close this issue.

Fix dab validate schema fetch Error from URL Azure/data-api-builder
3 participants
@Aniruddh25 @seantleonard @abhishekkumams