Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteById REST Support #172

Merged
merged 19 commits into from
Jan 31, 2022
Merged

DeleteById REST Support #172

merged 19 commits into from
Jan 31, 2022

Commits on Jan 28, 2022

  1. Initial work on DELETE for REST.

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    25390c8 View commit details
    Browse the repository at this point in the history

  2. Target .net6 and add additional logic to handle DeleteById

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    03f5877 View commit details
    Browse the repository at this point in the history

  3. Remove comments and consolidate DELETE Logic.

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    4e1d42d View commit details
    Browse the repository at this point in the history

  4. updated DELETE logic. Tests for SQL passing, WIP for postgres

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    acfc912 View commit details
    Browse the repository at this point in the history

  5. update comment spacing and summaries

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    8ec031b View commit details
    Browse the repository at this point in the history

  6. Revert back to .net5, fix graphqlpagination test to include new items… 

    … in db
    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    0d2b4c9 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary 'using' statement

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    6bb035e View commit details
    Browse the repository at this point in the history

  8. Fix placement of DataGateway Exception for NotFound vs unexpected ope… 

    …ration used
    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    30f20d0 View commit details
    Browse the repository at this point in the history

  9. Updated comments in RestService

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    005bf96 View commit details
    Browse the repository at this point in the history

  10. Fixed and updated comments in restservice/controller

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    b88142f View commit details
    Browse the repository at this point in the history

  11. updated comment

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    2d37ea2 View commit details
    Browse the repository at this point in the history

  12. Fixed comment

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    08ff015 View commit details
    Browse the repository at this point in the history

  13. updated hardcoded string for tests to variable _integrationTableName

    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    28f1772 View commit details
    Browse the repository at this point in the history

  14. Refactored tests and restController to return NotFound() for nonexist… 

    …ent items instead of Exception
    @seantleonard
    seantleonard committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    926e06b View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. Fix PostgreSQL tests for DELETE with updated param creation with Type.

    @seantleonard
    seantleonard committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    13b48ff View commit details
    Browse the repository at this point in the history

  2. Fixed typos in comments

    @seantleonard
    seantleonard committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    45b1412 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. String.Empty to null and PK deleteById validation added to address co… 

    …mments. Updated code comments.
    @seantleonard
    seantleonard committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    a93d0d0 View commit details
    Browse the repository at this point in the history

  2. update controller and tests to process NotFound as DataGatewayException

    @seantleonard
    seantleonard committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    c0640bb View commit details
    Browse the repository at this point in the history

  3. Fix whitespace issues in RequestValidator per build CI error

    @seantleonard
    seantleonard committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    e082e0f View commit details
    Browse the repository at this point in the history