[Cherrypick] Cache enablement check and dab-draft.schema.json changes #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why make this change? - Ensure cache is used when enabled and add additional checks to make this flow as expected. ## What is this change? - Change cache check to ensure dbpolicies are NOT resolved for request in order to use cache - Add check to ensure entity cache is enabled. ## How was this tested? - TBD
## Why this change? This change follows up on #1865, which adds caching support. VSCode suggesting the new `cache` properties were errors when included in the config file. That is because the properties needed to be added to the json schema. Global `cache` property in the `runtime` section which adjacent to `rest`, `graphql`, and `host`. ```json { "runtime": { "cache": { "enabled": false, "ttl-seconds": 5 } } } ``` and per entity alongside `source`, `graphql`, `rest`, and `permissions` ```json { "myEntity": { "cache": { "enabled": false, "ttl-seconds": 5 } } } ```
seantleonard
requested review from
mbhaskar,
Aniruddh25,
JelteF,
Mathos1432,
gledis69,
aaronburtle,
milismsft,
tarazou9,
ayush3797,
abhishekkumams,
aaronpowell,
severussundar and
ravishetye
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Aniruddh25
approved these changes
Feb 12, 2024
abhishekkumams
approved these changes
Feb 13, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks #2011 and #2012 to main
2012
Why make this change?
What is this change?
2011
Why this change?
This change follows up on #1865, which adds caching support.
VSCode suggesting the new
cacheproperties were errors when included in the config file. That is because the properties needed to be added to the json schema.Global
cacheproperty in theruntimesection which adjacent torest,graphql, andhost.{ "runtime": { "cache": { "enabled": false, "ttl-seconds": 5 } } }and per entity alongside
source,graphql,rest, andpermissions{ "myEntity": { "cache": { "enabled": false, "ttl-seconds": 5 } } }