-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos DB: Upgrade cosmos DB SDK to latest version i.e. 3.38.1 #2073
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There may not be tests for this.. how do we know DAB isn't affected by at least one of the breaking changes for CosmosSDK listed in : https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/changelog.md since we are upgrading from
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good question! but I don't think we have a scenario where tokens generated by newer DAB(that uses the new SDK) will be used by older DAB (that uses the old SDK). Because when client apps target a newer DAB, older DAB shouldn't be in picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the sdk!
FYI @sourabh1007 merging this, if you have concerns regarding breaking changes please address in a separate PR |
Why make this change?
We want to use SDK latest features like:
etc.
What is this change?
Upgrade Cosmos to the latest version
3.38.1
. It's a non-breaking changeHow was this tested?
NA
Sample Request(s)
NA