Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplicationInsights output should not require instrumentation key or configuration #91

Closed
karolz-ms opened this issue Jun 2, 2017 · 1 comment
Closed

ApplicationInsights output should not require instrumentation key or configuration #91

karolz-ms opened this issue Jun 2, 2017 · 1 comment

Comments

@karolz-ms
Copy link
Collaborator

In the AspNetCore application AI is configured through DI. That includes instrumentation key. The EventFlow AI output should just create a TelemetryClient and leverage DI-supplied configuration for it.
karolz-ms added a commit to karolz-ms/diagnostics-eventflow that referenced this issue Jun 14, 2017
@karolz-ms
AI output should not require instrumentation key or configuration
f0a362f 
Addresses issue Azure#91
@karolz-ms karolz-ms mentioned this issue Jun 14, 2017
Merged
karolz-ms added a commit that referenced this issue Jun 14, 2017
@karolz-ms
AI output should not require instrumentation key or configuration
03f344a 
Addresses issue #91
@karolz-ms
Copy link
Collaborator Author

Resolved with https://www.nuget.org/packages/Microsoft.Diagnostics.EventFlow.Outputs.ApplicationInsights/1.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karolz-ms