Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple clarifying questions and a suggestion to use batch explorers .io landing page
@@ -235,8 +235,15 @@ BatchUtilities <- R6::R6Class( | |||
commands <- c(commands, args$commandLine) | |||
} | |||
|
|||
commands <- linuxWrapCommands(commands) | |||
if (!is.null(args$applicationInsights)) { | |||
commands <- gsub("wait", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is wait something you add to the user cmd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we use wait for the following user cmd.
Note: Github has a rate limit of up to 60 requests per hour. Unauthenticated requests are associated with the originating IP address. [Link](https://developer.github.com/v3/#rate-limiting) | ||
|
||
For more information about these tools, | ||
- [Batch Explorer](https://github.com/azure/batchexplorer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will replace it.
# Usage: | ||
# setup_node.sh | ||
|
||
apt-get -y install linux-image-extra-$(uname -r) linux-image-extra-virtual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason for this being removed? Just unneeded now? I don't see it moved to code anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded code, once we moved to using Azure Batch's container image. This cluster setup is not needed.
@brnleehng The merge of this PR is the root cause of the bug I attempted to fix in #340. However, the bug fix did not succeed. By merging the present PR to master, the file at This change has broken the daily runs in our production system relying on Batch for two days now. What can I do to help fix this? |
#335