Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Add Windows support #158

Merged
merged 3 commits into from
Jun 19, 2017
Merged

Add Windows support #158

merged 3 commits into from
Jun 19, 2017

Conversation

alexpilotti
Copy link
Contributor

@alexpilotti alexpilotti commented Jun 17, 2017

Provides fixes for various Windows compatibility issues. Closes #157

Add conditional compilation to support Unix sockets on non Windows
platforms only.
@msftclas
Copy link

@alexpilotti,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

The environment variables that identifies the user's home on Windows is
named USERPROFILE.
@codecov-io
Copy link

codecov-io commented Jun 17, 2017

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is 13.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   33.15%   33.06%   -0.09%     
==========================================
  Files          17       18       +1     
  Lines        1098     1104       +6     
==========================================
+ Hits          364      365       +1     
- Misses        686      690       +4     
- Partials       48       49       +1
Impacted Files Coverage Δ
api/server.go 15.3% <ø> (+0.72%) ⬆️
cmd/draft/draft.go 2.81% <0%> (-0.13%) ⬇️
api/server_notwin.go 0% <0%> (ø)
cmd/draft/create.go 50% <100%> (ø) ⬆️
pkg/draft/pack/pack.go 53.84% <50%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d99d8...bc9ef30. Read the comment docs.

@alexpilotti alexpilotti changed the title Windows does not support Unix sockets Add Windows support Jun 17, 2017
Windows does not provide bash in /bin/bash. In the Windows case, the
user is resposible for adding bash.exe to the PATH.
@bacongobbler bacongobbler merged commit 18784fd into Azure:master Jun 19, 2017
mboersma pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows support
4 participants