Add .NET Core support #159
Conversation
|
@alexpilotti, |
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 33.06% 33.06%
=======================================
Files 18 18
Lines 1104 1104
=======================================
Hits 365 365
Misses 690 690
Partials 49 49Continue to review full report at Codecov.
|
|
23,000 LOC?! Can't we commit a much smaller example app? This seems a bit excessive for a hello world app. |
|
That's the very basic sample generated with "dotnet new mvc ..." as by readme.txt. I'm going to replace it with a smaller one :) |
|
@bacongobbler I replaced the sample. LOC count dropped significantly. :) |
|
this looks much better, thank you. You'll also need to do 2 things:
Once that's done, I'd be happy to merge. |
Add a Draft Starter Pack for .NET Core, supporting ASP.NET Core and .NET Core console applications.
The name of the assembly executed in the ENTRYPOINT needs to be retrieved automatically to avoid the need for the user to edit the Dockerfile.
This sample has been generated with the following .NET Core SDK command: dotnet new mvc -n WebApplication -o .
|
@bacongobbler done, I put the autogenerated file change in a separate commit, fixed the test as well |
|
thank you so much! :) |
Includes a .NET Core Starter Pack and an example