Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating AZ commands to work after upgrade #96

Merged
merged 2 commits into from May 25, 2022
Merged

Conversation

erinborders
Copy link
Contributor

Following an error Karen and Quentin were experiencing with the setup-gh command, I was able to reproduce it and determined that it was caused by an update to the "az ad sp" and "az ad app" commands. They no longer return "objectId" in the json response when you create, list or show them, instead they just return "id". That meant that the commands to assign roles and created FICs weren't working either because they rely on the sp and app "objectId"s

Changes:

  • changed sp list to sp show since we really don't need to query a list to get one sp
  • changed any queries for an "objectId" to an "id"
  • removed the first sp exists check since new apps don't automatically have sp's

@imiller31
Copy link
Collaborator

Interesting did you find any documentation from the aad APIs? We should be able to link this to a public API change.

@erinborders
Copy link
Contributor Author

yeah the command itself sends you to this link about the command group being migrated, which references some breaking property changes - objectId is included but there are a bunch of others too

@erinborders erinborders merged commit cfb0440 into main May 25, 2022
@erinborders erinborders deleted the eborders/spExistsCheck branch May 25, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants