Merge More Main Changes to Azure Storage v12 Branch #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons (Azure#892) * [AzureServiceFabric] Handle missing ExecutionStartedEvent orchestrations --------- Co-authored-by: Shankar Reddy Sama <shsama@microsoft.com>
…zure#896) Co-authored-by: Shankar Reddy Sama <shsama@microsoft.com>
…zure#898) * Bumping up DurableTask.AzureServicefabric package version to 2.3.8 * [AzureServiceFabric] Fix issues related to Terminate orchestration * Fixed comments and usings * Fixed remote client to read http error message --------- Co-authored-by: Shankar Reddy Sama <shsama@microsoft.com>
…onAsync and fix session query in ContainsSessionAsync (Azure#900) * [AzureServiceFabric] Fix ArgumentNullException in CompleteOrchestrationAsync * Use OrchestrationInstance while finding the session to avoid conflicts --------- Co-authored-by: Shankar Reddy Sama <shsama@microsoft.com>
… to 2.3.9 (Azure#902) Co-authored-by: Shankar Reddy Sama <shsama@microsoft.com>
…es (Azure#891) * add randomization to blob names when uploading history, to prevent races in split-brain situations * track all the blobs associated with an execution, and remove them when updating the tracking store after a continue-as-new * modify blobName slightly so existing tests still pass. * address PR feedback * address PR feedback. * Apply suggestions from code review Co-authored-by: David Justo <david.justo.1996@gmail.com> * address PR feedback --------- Co-authored-by: David Justo <david.justo.1996@gmail.com>
…nable nullable checks (Azure#910)
Update GetMessageAsync log information, add the reason LeaseLost.
* update * remove unnecessart pkg * update test * update drain process && test storage connection * update commit * update scaletests pm setting * udpate commit * update commit * Update AzureStorageScaleTests.cs * test UseTablePartitionManager setting * remove typo * change UseTablePartitionManager = true * update null reference * add control queue in AzureOrchestratorService * update commit * Update AzureStorageScaleTests.cs * commit KillThreeWorker tests * update GetControlQueueAsync * update partition table name setting * update log && commits && add new method to check alignment with owned queues and ownership lease * remove typo and sort using * update commit * add tests * update according to commits * change test connection setting * update according to reviews * mark one test disabled for now cause it's flaky * Update DurableTask.AzureStorage.csproj * Update DurableTask.AzureStorage.csproj * reconstruct ReadAndWriteTable method to be more readable * udpate connection string setting * update connection string setting * update test according to commits and update connection string setting * update connection string setting * update logs * update typo * update tests * update catch exceptions and logs * remove typo * update lease balancer and log * remove unused package * update commits * Update AzureStorageScaleTests.cs for commits * update commit * update commits: drain process * update checkownershiplease from void to task * mark test disabledinci * update according to commit * remove test version * Suggested edits for table partition manager (Azure#921) * update shutdown process to avoid race condition * update shutdown process into one loop to avoid race condition * add commit * More suggested edits (Azure#922) * More suggested edits * Sync'd with latest and added additional refactoring * Adding a few corrections to my previous commit * add new method CheckDrainTask to avoid redundant code * update commit * update shutdown wait time && KillLoop * update commit * Update AppLeaseManager.cs Remove unrelated file using change. * update AzureStorage version * update AzureStorage version * update commit for AcquireInterval * update commit for AcquireInterval * update commit --------- Co-authored-by: Chris Gillum <cgillum@microsoft.com>
wsugarman
commented
Jul 28, 2023
|
Adding @nytian to help review this PR and answer Will’s questions. |
nytian
approved these changes
Aug 1, 2023
Oh, I changed it as all other interactions with Azure Storage, including the existing partition manager, leverage these client wrappers. For example, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainincluding the new table partition manager into the feature branchTablePartitionManagerto use theTableclass instead of theTableClientdirectlyTableLeasetoTablePartitionLeaseto align withBlobPartitionLeaseThis change should not be squashed as I will eventually need to merge with
maintoo.