SF Provider: memory leak: Create a new scope in HTTP controller DI on each BeginScope call #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2023 23:56
… every BeginScope call
shankarsama
approved these changes
Aug 3, 2023
nytian
pushed a commit
that referenced
this pull request
Aug 16, 2023
* SF Provider: memory leak: Create a new scope in HTTP controller DI on each BeginScope call (#933) * SF Provider: memory leak: Create a new scope in HTTP controller DI on every BeginScope call * Bump up package version --------- Co-authored-by: Abhineet Garg <abhigarg@microsoft.com> * Update SDK versions * Use Uri property * Update table sdk again --------- Co-authored-by: NeetArt <20233106+NeetArt@users.noreply.github.com> Co-authored-by: Abhineet Garg <abhigarg@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new scope in HTTP controller dependency injection on each BeginScope call
Previous implementation used a single root scope for all HTTP requests. As the scope was never disposed, so didn't the controller & HTTP request/response objects, causing them to get accumulated in memory.
This change creates a new scope in
BeginScope()API which will be disposed by request handler when the request completes. More information can be found here: Dependency Injection in ASP.NET Web API 2 - ASP.NET 4.x | Microsoft Learn