Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose middleware properties in activity/orchestrator #963

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

twsouthwick
Copy link
Contributor

@twsouthwick twsouthwick commented Sep 8, 2023

The properties bag from DispatchMiddlewareContext contains information
that might be useful from activities/orchestrators. However, they
currently do not show up from those context options. This change plumbs
the dictionary through and surfaces it for both activities and
orchestrators.

As part of this, the following changes are introduced to show a use case for sharing properties:

  • A new interface IContextProperties is added that just has the properties dictionary. However, this allows for shared code to
    set and get properties by type or by name.
  • A .Properties member is added to the activity and orchestration contexts
  • The serializers for messages and errors are retrieved from the .Properties so that they can be configured in middleware

If it would be easier to have just the properties change, I can separate the serializer change out.

The properties bag from DispatchMiddlewareContext contains information
that might be useful from activities/orchestrators. However, they
currently do not show up from those context options. This change plumbs
the dictionary through and surfaces it for both activities and
orchestrators.

As part of this, a new interface IContextProperties is added that just
has the properties dictionary. However, this allows for shared code to
set and get properties by type or by name.
@davidmrdavid
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants