Fixing a bug where we were bottlenecking on frames that had bodies smaller than 8 bytes #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… body length was smaller than the standard frame header (8 bytes). Moving it within the portion of the reader that deals with parsing headers.
richardpark-msft
requested review from
jhendrixMSFT and
RickWinter
as code owners
berndverst
approved these changes
Mar 1, 2024
jhendrixMSFT
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frame parsing code parses in two stages - headers, which tells you the body length, and the body itself. If the body was < 8 bytes (the standard frame header size) we'd end up skipping the body parse until we accumulated at least 8 bytes worth of material.
The fix is simple - move the "frame header size" check into the frame header portion of the parsing code.