Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSAL Support? #636

Closed
princjef opened this issue Jun 1, 2021 · 4 comments
Closed

MSAL Support? #636

princjef opened this issue Jun 1, 2021 · 4 comments

Comments

@princjef
Copy link
Member

princjef commented Jun 1, 2021

With the push to migrate from ADAL to MSAL, has there been any discussion of moving this module and the clients generated with it (such as those in the Azure SDK for Go) from ADAL/v1.0 to MSAL/v2.0 for auth? ADAL stopped receiving new features a year ago.

It looks like the AAD team has an early preview of an official MSAL package for golang which may be useful rather than trying to reimplement the auth patterns already present in this repository: https://github.com/AzureAD/microsoft-authentication-library-for-go. With that said, that package seems to be in evaluation mode right now, so I'm not sure what steps would be needed to integrate it.

@jhendrixMSFT
Copy link
Member

Our updated authentication module is azidentity, and while it doesn't use MSAL at present, it will at some point.
We won't be migrating the content in go-autorest to use MSAL as it will be retired in favor of azidentity.

@shueybubbles
Copy link

Let's say we wanted to contribute full AAD auth support to the go-mssql driver to simplify Go app development against Azure SQL Database and Managed Instance.

  1. Which of the various Go libraries (azidentity, autorest\adal, msal for go) should we use as the long term solution in such an integration?
  2. Should we (Sql team at Microsoft) register a first party client id for the go-mssql driver to relieve the burden on every user of it from having to register an app to connect to SQL DB? IE can we follow the same model Microsoft.Data.SqlClient followed?

@jhendrixMSFT
Copy link
Member

@shueybubbles sorry for the delay.

For your first bullet, azidentity is the path forward for AAD authentication.

I don't have an answer to your second bullet, might be worth following up internally with additional people to find the right solution.

@jhendrixMSFT
Copy link
Member

Closing as we won't be adding MSAL support to go-autorest. We can follow up on any other items separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants