Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from use of go-autorest for authentication #1566

Closed
viveklak opened this issue Mar 11, 2022 · 1 comment
Closed

Migrate away from use of go-autorest for authentication #1566

viveklak opened this issue Mar 11, 2022 · 1 comment
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@viveklak
Copy link
Contributor

viveklak commented Mar 11, 2022

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

As per Azure/go-autorest#636 - with the push to migrate from ADAL to MSAL, the use of go-autorest for authentication is starting to cause issues. See #1565 for instance. It appears there is no plan to add MSAL authentication support to go-autorest and the proposal is to use the azidentity package in the AZ go sdk: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azidentity. We should migrate to this model for the azure-native provider.

Affected area/feature

  • getClientConfig
  • Authentication
@viveklak viveklak added the kind/enhancement Improvements or new features label Mar 11, 2022
@stack72
Copy link
Contributor

stack72 commented Jul 7, 2022

So @danielrbradley and I just had a small conversation about this and after some small thoughts we believe:

  • We should support BOTH authentication styles for an undetermined period of time to allow transition
  • the current authentication system will stay the default BUT we should be able to opt-in to the new authentication system
    • pulumi config set azure-native:auth future true or a determined config name
  • This work will not happen as part of the 2.0 launch but will be the first thing we handle after the 2.0 work
  • in 3.0, the future authentication will be made the default experience

@stack72 stack72 added this to the 0.77 milestone Aug 19, 2022
thomas11 added a commit that referenced this issue Aug 23, 2022
thomas11 added a commit that referenced this issue Aug 23, 2022
thomas11 added a commit that referenced this issue Aug 24, 2022
thomas11 added a commit that referenced this issue Aug 26, 2022
@thomas11 thomas11 modified the milestones: 0.77, 0.78 Sep 6, 2022
@lukehoban lukehoban modified the milestones: 0.78, 0.79 Oct 6, 2022
@lukehoban lukehoban modified the milestones: 0.79, 0.80 Nov 7, 2022
@mikhailshilkov mikhailshilkov removed this from the 0.80 milestone Nov 15, 2022
@thomas11 thomas11 added the resolution/fixed This issue was fixed label Aug 9, 2023
@thomas11 thomas11 closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

5 participants