Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor LockRenewer and Enable Compatibility with MultiProcessor #222

Merged
merged 9 commits into from
Apr 23, 2024

Conversation

karenychen
Copy link
Contributor

@karenychen karenychen commented Apr 22, 2024

  • Refractor NewLockRenewalHandler to NewRenewLockHandler. The refractor gets rid of the lockRenewer argument in the constructor and instead uses the settler passed down from the handler function.
  • Deprecate NewLockRenewalHandler
  • The refractor also enables compatibility with MultiProcessor. The lock renewal handler now will automatically take in the correct settler for each receiver in the MultiProcessor.
    • Added UT to verify compatibility.

@coveralls
Copy link
Collaborator

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8792332775

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 86.03%

Totals Coverage Status
Change from base Build 8791540516: 0.4%
Covered Lines: 739
Relevant Lines: 859

💛 - Coveralls

@karenychen karenychen changed the title Refractor RenewLockHandler and Enable Compatibility with MultiProcessor Refractor LockRenewer and Enable Compatibility with MultiProcessor Apr 22, 2024
@karenychen karenychen marked this pull request as ready for review April 22, 2024 23:29
@karenychen karenychen merged commit 504c51a into main Apr 23, 2024
5 checks passed
@karenychen karenychen deleted the karenchen/lockrenewalhandler-refractor branch April 23, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants