Keptn executor #12

nitishm · 2021-08-27T18:31:42Z

Closes #3

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

…m/nitishm/orkestra-workflow-executor into nitishm/feat/3/add-keptn-executor

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Signed-off-by: Nitish Malhotra <nitishm@Nitishs-MacBook-Pro.local>

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

jonathan-innis · 2021-08-30T05:47:10Z

executors/keptn/go.mod

+replace (
+	github.com/docker/distribution => github.com/docker/distribution v0.0.0-20191216044856-a8371794149d
+	github.com/docker/docker => github.com/moby/moby v1.4.2-0.20200203170920-46ec8731fbce
+// k8s.io/api => k8s.io/api v0.20.2


Why is this left here commented out?

possibly cruft from some experiments I was performing with keptn

jonathan-innis · 2021-08-30T05:47:28Z

executors/keptn/main.go

@@ -0,0 +1,122 @@
+package main
+
+// https://socialsign.in/spot?nbiIP=100.124.9.55&loc=4176656e74696e65&client_mac=38:F9:D3:B5:DD:FB&domain_name=San+Diego&reason=Un-Auth-Captive&lid=network%3Dsd02&wlanName=WeWorkGuest&dn=scg.ruckuswireless.com&ssid=WeWorkGuest&mac=44:1e:98:39:aa:b0&url=http%3A%2F%2F10.239.22.1%2F&proxy=0&vlan=22&wlan=19&sip=scg.ruckuswireless.com&zoneName=tS-IA_qoXMRjSxWeD6KI8A_1627936773232&apip=10.239.12.175&sshTunnelStatus=1&uip=10.239.22.176&StartURL=https%3A%2F%2Fsocialsign.in%2Fspot%2Fsuccess


What is this for?

😆 I think I was trying to keep a link that I kept loosing and added it as a comment on the first editor screen I had open. Will remove

jonathan-innis · 2021-08-30T05:47:58Z

executors/keptn/main.go

+	"sigs.k8s.io/controller-runtime/pkg/client"
+)
+
+const (


Can this be put into a common pkg?

I suppose so - maybe once we break out each executors into their own repos we can leverage the pkg/utils repo as we discussed earlier in the Orkestra PR?

jonathan-innis · 2021-08-30T05:48:25Z

executors/keptn/main.go

+	var intervalStr string
+
+	// Default executor params
+	flag.StringVar(&spec, "spec", "", "Spec of the helmrelease object to apply")


Same here. Maybe some flagparse helpers that are availble to all executors if there is crossover

jonathan-innis · 2021-08-30T05:54:03Z

executors/keptn/pkg/status/polling.go

+
+// Poll retries the poller function, sleeping for the given backoffDuration
+// If the poller times out it will return an error
+func Poll(ctx context.Context, poller func(chan<- bool), backoffDuration time.Duration) error {


Again, let's create a common directory

Will move into the pkg/utils repo since each executor will now get its own repository.

jonathan-innis · 2021-08-31T06:03:24Z

executors/keptn/pkg/actions/install.go

+		return err
+	}
+
+	for k, v := range data {


Can we use more specific names than k and v?

Convention in Go states use single char variables but if it helps I can expand it to give more context (I will do that)

jonathan-innis · 2021-08-31T06:04:20Z

executors/keptn/pkg/keptn/keptn.go

+
+func (k *Keptn) AddResourceToStage(service, project, stage, resourceURI, resourceContent string) error {
+	// encodedResourceContent := base64.StdEncoding.EncodeToString([]byte(resourceContent))
+	encodedResourceContent := resourceContent


Why rename? This looks like it could be removed

yea I think it was cruft left from the comment above. Will remove.

jonathan-innis · 2021-08-31T06:08:15Z

executors/keptn/pkg/keptn/keptn.go

+		return fmt.Errorf("expected to see one event of type %s", filter.EventType)
+	}
+
+	if dataMap, ok := eventsCtx[0].Data.(map[string]interface{}); ok {


Does keptn have a struct format of this so we don't have to use interface{} and type-casting?

unfortunately, the data is an opaque blob of data 😞 .

jonathan-innis · 2021-08-31T06:09:00Z

executors/keptn/pkg/keptn/keptn.go

+		return "", err
+	}
+
+	stage := stages[0].StageName


Why just the first stage?

We only ever use one stage. In the future we might support this but today we do not plan to do so

jonathan-innis · 2021-08-31T06:11:30Z

executors/keptn/pkg/keptn/testwith/helmrelease.yaml

@@ -0,0 +1,13 @@
+apiVersion: helm.fluxcd.io/v2beta1


What's all the testwith code doing this deep? Also, would help to have an understanding of what exactly this is doing.

This was mostly for reference - its more docs like that testwith. Let me move it into the executors/keptn dir instead as a documentation dir.

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

nitishm and others added 15 commits July 13, 2021 15:09

Gitea repo and Keptn auth, project and service creation

16ce1b4

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Fix helm package and implement add resource keptn

330557c

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Read resources from configmap

431274c

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

keptn config from configuration file

69112a7

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

instructions and resources for running keptn against webserver

a3f428a

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

instructions and resources for running keptn against webserver

6c5843f

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Merge branch 'nitishm/feat/3/add-keptn-executor' of https://github.co…

516ea1e

…m/nitishm/orkestra-workflow-executor into nitishm/feat/3/add-keptn-executor

Trigger evaluation and configure prometheus monitoring

9e15439

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Init

eb7bd55

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

trigger evaluation successfully

23e7015

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Update delete handler to delete project

cd956d0

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Return keptnCtx from evalution and start status poller

73985bb

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Poll for events

bb162dc

Signed-off-by: Nitish Malhotra <nitishm@Nitishs-MacBook-Pro.local>

Sample configmap for webserver keptn eval

e95565a

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Switch to createOrUpdate function for project

e66090d

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

nitishm requested a review from jonathan-innis as a code owner August 27, 2021 18:31

Added makefile

3d5e89e

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

nitishm force-pushed the nitishm/feat/3/add-keptn-executor branch from 463317a to dd74a2f Compare August 27, 2021 18:46

Add keptn to workflow

82464c0

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

nitishm force-pushed the nitishm/feat/3/add-keptn-executor branch from dd74a2f to 82464c0 Compare August 30, 2021 16:51

jonathan-innis suggested changes Aug 31, 2021

View reviewed changes

Address PR review comments

0d40e41

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keptn executor #12

Keptn executor #12

nitishm commented Aug 27, 2021 •

edited

Loading

jonathan-innis Aug 30, 2021

nitishm Aug 31, 2021

jonathan-innis Aug 30, 2021

nitishm Aug 31, 2021

jonathan-innis Aug 30, 2021

nitishm Aug 31, 2021

jonathan-innis Aug 30, 2021

jonathan-innis Aug 30, 2021

nitishm Aug 31, 2021

jonathan-innis Aug 31, 2021

nitishm Aug 31, 2021

jonathan-innis Aug 31, 2021

nitishm Aug 31, 2021

jonathan-innis Aug 31, 2021

nitishm Aug 31, 2021

jonathan-innis Aug 31, 2021

nitishm Aug 31, 2021

jonathan-innis Aug 31, 2021

nitishm Aug 31, 2021

		@@ -0,0 +1,122 @@
		package main

		// https://socialsign.in/spot?nbiIP=100.124.9.55&loc=4176656e74696e65&client_mac=38:F9:D3:B5:DD:FB&domain_name=San+Diego&reason=Un-Auth-Captive&lid=network%3Dsd02&wlanName=WeWorkGuest&dn=scg.ruckuswireless.com&ssid=WeWorkGuest&mac=44:1e:98:39:aa:b0&url=http%3A%2F%2F10.239.22.1%2F&proxy=0&vlan=22&wlan=19&sip=scg.ruckuswireless.com&zoneName=tS-IA_qoXMRjSxWeD6KI8A_1627936773232&apip=10.239.12.175&sshTunnelStatus=1&uip=10.239.22.176&StartURL=https%3A%2F%2Fsocialsign.in%2Fspot%2Fsuccess

Keptn executor #12

Are you sure you want to change the base?

Keptn executor #12

Conversation

nitishm commented Aug 27, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nitishm commented Aug 27, 2021 •

edited

Loading