Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split client and server into independent packages #174

Merged
merged 6 commits into from Jun 29, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Jun 15, 2017

This pull request makes the server and client packages independently deployable and runnable. This makes the developer story slightly worse (we now have to run two servers in separate shells, see updates in readme), but it gives us a number of benefits, including:

  • Better long-term maintainability by increasing the logical separation between client and server.
  • Option to have client and server depend on different versions of the same package. This is a requirement for using GraphQL+Apollo since the Apollo React client and the Apollo Express server rely on different versions of the Apollo core library.
  • Ability to publish client and server as independent npm modules, e.g. to deploy them to separate webapps or to include them selectively in third-party pages.

This pull request is a necessary pre-condition for a potential Fortis/Ibex integration, but has value on its own for the reasons mentioned above. As such, I propose to merge this pull request before we start the Fortis/Ibex integration.

c-w added some commits Jun 14, 2017

Install yarn explicitly
Previously Travis auto-installed yarn for us because we had a yarn.lock
file in the repository root -- now we no longer have this so we have to
manually set it up.

@c-w c-w requested a review from morsh Jun 15, 2017

@morsh morsh removed their assignment Jun 26, 2017

@morsh morsh added this to the Ibex vnext milestone Jun 27, 2017

@morsh morsh merged commit 528d073 into ibex-version-1.0 Jun 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.