This repository was archived by the owner on Feb 18, 2021. It is now read-only.
Split client and server into independent packages - #174
Merged
Conversation
Previously Travis auto-installed yarn for us because we had a yarn.lock file in the repository root -- now we no longer have this so we have to manually set it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the server and client packages independently deployable and runnable. This makes the developer story slightly worse (we now have to run two servers in separate shells, see updates in readme), but it gives us a number of benefits, including:
This pull request is a necessary pre-condition for a potential Fortis/Ibex integration, but has value on its own for the reasons mentioned above. As such, I propose to merge this pull request before we start the Fortis/Ibex integration.