Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Fix Java binding build error on Windows #259

Merged
merged 1 commit into from
May 15, 2017

Conversation

yfakariya
Copy link
Contributor

This PR fixes Java binding build error on Windows caused by default java compiler encoding specified by maven.

For your information, there are build error message when I tried on Japanese Windows:

[INFO] --- maven-compiler-plugin:3.3:testCompile (default-testCompile) @ gateway-java-binding ---
[INFO] Changes detected - recompiling the module!
[WARNING] File encoding has not been set, using platform encoding MS932, i.e. build is platform dependent!
[INFO] Compiling 2 source files to path\to\gwsdk\bindings\java\gateway-java-binding\target\test-classes
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[281,27] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[281,33] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[281,40] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[281,46] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[282,27] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[282,38] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[284,36] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[284,42] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[292,25] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[292,31] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[292,59] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[292,65] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[293,25] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[293,57] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[294,37] この文字は、エンコーディングMS932にマップできません
[ERROR] /path/to/gwsdk/bindings/java/gateway-java-binding/src/test/java/tests/unit/com/microsoft/azure/gateway/messaging/MessageTest.java:[294,43] この文字は、エンコーディングMS932にマップできません

This PR fixes above compilation errors.

@msftclas
Copy link

@yfakariya,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Unless this element, mvn uses ANSI encoding to compile *.java,
this causes compilation error of test sources.
@az-iot-builder-01 az-iot-builder-01 merged commit 1175924 into Azure:master May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants