Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Configrable RetryPolicy for IotHub -module #382

Merged
merged 2 commits into from
Sep 11, 2017
Merged

Configrable RetryPolicy for IotHub -module #382

merged 2 commits into from
Sep 11, 2017

Conversation

villepalo
Copy link
Contributor

  • Added RetryPolicy configuration json field
  • devdoc updates
  • Updated old ones and added some new unit tests
  • Updated configuration json files of all samples using IotHub module

Issue refence: #378

@villepalo
* Added RetryPolicy configuration json field
108c2cb 
* devdoc updates
* Updated old ones and added some new unit tests
* Updated configuration json files of all samples using IotHub module
@msftclas
Copy link

msftclas commented Sep 7, 2017

@villepalo,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

msftclas commented Sep 7, 2017

@villepalo, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@darobs
Copy link
Contributor

darobs commented Sep 8, 2017 •
edited
Loading

Only one comment so far - instead of requiring the retry policy in the JSON, we'd prefer a default if it's not set. That would better maintain backward compatibility.

(The default should be "EXPONENTIAL_BACKOFF_WITH_JITTER".)

@villepalo
Review fixes:
2c9877c 
* RetryPolicy default field is not mandatory. Default value is EXPONENTIAL_BACKOFF_WITH_JITTER.
* Updated unit tests
@villepalo
Copy link
Contributor Author

I thought about it long and hard and then made the wrong decision :)

@darobs
Copy link
Contributor

darobs commented Sep 11, 2017

Thank you @villepalo, I'll run this through our build gate and let you know if any trouble comes up.

@az-iot-builder-01 az-iot-builder-01 merged commit 2c9877c into Azure:master Sep 11, 2017
@villepalo villepalo deleted the iothub_retry_policy branch September 15, 2017 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@villepalo @msftclas @darobs @az-iot-builder-01