Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.8.0] Yocto meta layer changes permission of folder twice ... wrong variable? #127

Closed
SimonSimCity opened this issue Feb 18, 2022 · 1 comment
Assignees
Labels
area: yocto There is an issue with Yocto meta-layers

Comments

@SimonSimCity
Copy link

SimonSimCity commented Feb 18, 2022

While comparing the changes from the yocto meta layer, provided in this repo as artifacts, I wondered about the changes supplied in the receipe azure-device-update:

At first this looked suspicious that the permissions for the folder ADUC_DOWNLOADS_DIR are changed in a block meant for ADUC_LOG_DIR:

https://github.com/munit-solutions/meta-azure-device-update/blob/7b237fa76d7c34919f074f85af1d36b9b99818a9/recipes-azure-device-update/azure-device-update/azure-device-update_git.bb#L156-L159

And then I found out that you change the permissions of that folder just a few lines above already:

https://github.com/munit-solutions/meta-azure-device-update/blob/7b237fa76d7c34919f074f85af1d36b9b99818a9/recipes-azure-device-update/azure-device-update/azure-device-update_git.bb#L145-L148

Could it be that you mixed up the naming of the variables there?

SimonSimCity pushed a commit to munit-solutions/meta-azure-device-update that referenced this issue Feb 18, 2022
@SimonSimCity SimonSimCity changed the title Yocto meta layer changes permission of folder twice ... wrong variable? [0.8.0] Yocto meta layer changes permission of folder twice ... wrong variable? Feb 18, 2022
SimonSimCity pushed a commit to munit-solutions/meta-azure-device-update that referenced this issue Feb 18, 2022
@Nox-MSFT
Copy link
Contributor

Hi @SimonSimCity , I've updated the asset in the 0.8.0 Release Page with the changes you've suggested.

Thank you for you contribution!

@eshashah-msft eshashah-msft added the area: yocto There is an issue with Yocto meta-layers label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: yocto There is an issue with Yocto meta-layers
Projects
None yet
Development

No branches or pull requests

3 participants