SWUpdate Handler V2 and Script Handler improvements related to --installed-criteria and --work-folder option #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if "handlerProperties.installedCriteria" is specified. - SWUpdateHandler V2: Only pass "--installed-criteria" option to the script if "handlerProperties.installedCriteria" is specified. - Fix typo in ScriptHandler README.md
Update SWUpdate Handler V2 example scripts to handle "--work-folder" options
Nox-MSFT
changed the title
JeffMill
previously approved these changes
Jan 30, 2023
| @@ -783,14 +783,26 @@ ADUC_Result SWUpdateHandlerImpl::PrepareCommandArguments( | |||
| } | |||
|
|
|||
| // Default options. | |||
|
|
|||
| // Note: Add '--workfolder' option here for backward compatibility. | |||
There was a problem hiding this comment.
was 'workfolder' ever supported? I think it would be better to remove entirely, unless HILO (or some other customer with a product in production) is depending on it
JeffMill
approved these changes
Jan 30, 2023
JeffMill
pushed a commit
that referenced
this pull request
Jan 31, 2023
…alled-criteria and --work-folder option (#366)
jw-msft
added a commit
that referenced
this pull request
Jun 19, 2023
* Merge 'develop' into 'main' (#243) (#262) (#264) Fix issue in reboot/restart flow and race condition in D2C messaging util (#242) - Fix an issue for image-based update scenario where the device doesn't reboot after the new image is installed. - Add ADUC_D2C_Message_Type_Device_Properties to avoid a race condition. Note | These changes passed e2e verification internally. Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> * Use 'bool' instead of '_Bool' (#268) * sort paths before asserting in systemutils_forEachDir tests (#265) * sort paths before asserting in systemutils_forEachDir tests * Revamp test to fully utilize test fixture instance and have bare minimum test code * clang-format * Remove stale debug trace from main() (#257) * Fix many memory leaks and reenable UT (#283) * fix memleak in workflow_get_workfolder * Fix leak of hash array in workflow_get_update_file * remove unused include in steps_handler * clang-format steps_handler * Remove unused include in file_test_utils * memleak, use workflow_free in AutoWorkflowHandle * split autoopendir impl, throw on opendir failure * make findFilesInDir iterative, guard non-dir arg * uncomment source_update_cache_utils unit tests * Fix many memleaks (valgrind) in MoveToUpdateCache * Remove curl dependency in https_proxy_utils (Bug 42504722) (#282) * Remove curl dependency in https_proxy_utils * PR comments * Remove mallocAndStrcpy_s header * Update encoded test * log result.ResultCode instead of result on nested edge startup failure (#280) * remove do dep packages * fix install_aduc_deps * Handle errors when download handler plugin symbol missing (#284) * Make DH Factory LoadDownloadHandler noexcept * Make DH Plugin noexcept * throw plugin exception, extract DH extmgr helper * Fix ProcessDownloadHandlerExtensibility docs * Add missing Log_Error for caught PluginException * create erc for each dh export and rmv catch in ADUC_DownloadHandlerPlugin_OnUpdateWorkflowCompleted * Bug 42442896: zlog - incorrect threadproc signature (#287) * Removed log message for retrieving connection information from connection string (#292) * Updated doxygen version (#289) * Updated doxygen version * Changed product name to reflect documentation and removed pre-version * Changed install-deps to clean up after itself (#295) * Updated install-deps to remove old files and cleanup after itself * Fixed script errors * one line fix (#297) * use helper for recursive mkdir (#301) * Try to reconnect to IoT Hub on bad credential or expired SAS token (when using AIS) (#298) * Fix undefined references error in adu-shell (#305) * Took Jeff's suggestion for removing the pthread_cancel calls (#302) * Turn d2c_messaging unit tests into functional tests and skipped by default. (#306) * use TestCaseFixture ptr, not void ptr (#308) * fix zlog file handle leak (#310) * fix zlog file handle leak * set ret=1 upfront and ret 1 when RunAsDesiredUser returns false * rmv last ret=1 straggler * CP: Fix up issues with d2c_messaging. Working on WIOT. Needs to be brought to develop. (#314) Co-authored-by: Jeff Miller <jeffmill@microsoft.com> * Fix build pipeline by fixing cpp-tidy errors (#313) * Fix deadlock in zlog flush deinit (#315) * Fix deadlock in zlog finish flush * rmv flush thread * use zlog_flush_buffer and init zlog_last_flushed to 0 * Fix regression in ADUC_Logging_Init to allow agent to start (#317) * Update cached workfolder when processing replacement workflow (#322) Fixes issue where replacement workflow processing uses the previous workflow's workfolder sandbox that was in the property cache. * Update README.md (#294) * Moved the output of catch from cout to cerr for all CATCH_CONFIG_RUNNER unit tests (#323) * Mark test case "30 retries - httpStatus 401" as functional - takes 30s to run (#325) Co-authored-by: Jeff Miller <jeffmill@microsoft.com> * cherry-pick from wiot-s1 feature branch: GetConnectionInfoFromConnectionString crashes on failure. (#324) (#326) Co-authored-by: Jeff Miller <jeffmill@microsoft.com> * Fix overwrite of contract maj ver in downloaders and comp enumerator (#327) * fix contract majVer overwrite with minVer in content downloaders and content enumerator * fix contract comparison logic * Fixes the E2E Pipeline so all tests pass and scenarios are run (#329) * Removing the cppcheck and clang-tidy to see if that is what is causing the pipeline builds to fail * Making linking changes to see if that fixes the build error * Adding debug lines * Added timeout failures * Added call to set device name when configuring agent through config file - fixes diagnostics * Removed output of the connection string during test * Added input params checks to ConnectionStringUtils_IsNestedEdge to prevent test failures (#330) * Added input params check to prevent bad access * Changed null check to IsNullOrEmpty() * Upgraded patch version (#331) * Fix bug in swupdate-handler v2 example (#333) * Solving merge conflicts main to develop (#338) * Merge 'develop' into 'main' (#243) Fix issue in reboot/restart flow and race condition in D2C messaging util (#242) - Fix an issue for image-based update scenario where the device doesn't reboot after the new image is installed. - Add ADUC_D2C_Message_Type_Device_Properties to avoid a race condition. Note | These changes passed e2e verification internally. * Update issue templates * Update issue templates * Update issue templates Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Esha Shah <92388818+eshashah-msft@users.noreply.github.com> * Merge remote-tracking branch 'origin/main' into develop (#341) * Merge 'develop' into 'main' (#243) Fix issue in reboot/restart flow and race condition in D2C messaging util (#242) - Fix an issue for image-based update scenario where the device doesn't reboot after the new image is installed. - Add ADUC_D2C_Message_Type_Device_Properties to avoid a race condition. Note | These changes passed e2e verification internally. * Update issue templates * Update issue templates * Update issue templates * Patch 1.0.1 Release (#340) * Fix issue in reboot/restart flow and race condition in D2C messaging util (#242) * - Fix an issue for image-based update scenario where the device doesn't reboot after the new image is installed. - Add ADUC_D2C_Message_Type_Device_Properties to avoid a race condition. * Update steps_handler.cpp * Update steps_handler.cpp * Update workflow_utils.c Remove comment * Address PR feedback * Update how-to-build-agent-code.md * Manually integrate PR #58 Co-authored-by: Pierrick Arsenault <pierrick.arsenault@stello.ca> * revert clang-format.sh to avoid issues when pipe in staged content * Disable clangformat in precommit hook due to cross ver compat * Fix install-deps issue when --work-folder used on ubuntu 20.04 * Cleanup sandbox on start of deployment processing (#247) * Added README section for Azure CLI (#254) * Merge 'develop' into 'main' (#243) (#262) (#264) Fix issue in reboot/restart flow and race condition in D2C messaging util (#242) - Fix an issue for image-based update scenario where the device doesn't reboot after the new image is installed. - Add ADUC_D2C_Message_Type_Device_Properties to avoid a race condition. Note | These changes passed e2e verification internally. Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> * Use 'bool' instead of '_Bool' (#268) * sort paths before asserting in systemutils_forEachDir tests (#265) * sort paths before asserting in systemutils_forEachDir tests * Revamp test to fully utilize test fixture instance and have bare minimum test code * clang-format * Remove stale debug trace from main() (#257) * Fix many memory leaks and reenable UT (#283) * fix memleak in workflow_get_workfolder * Fix leak of hash array in workflow_get_update_file * remove unused include in steps_handler * clang-format steps_handler * Remove unused include in file_test_utils * memleak, use workflow_free in AutoWorkflowHandle * split autoopendir impl, throw on opendir failure * make findFilesInDir iterative, guard non-dir arg * uncomment source_update_cache_utils unit tests * Fix many memleaks (valgrind) in MoveToUpdateCache * Remove curl dependency in https_proxy_utils (Bug 42504722) (#282) * Remove curl dependency in https_proxy_utils * PR comments * Remove mallocAndStrcpy_s header * Update encoded test * log result.ResultCode instead of result on nested edge startup failure (#280) * remove do dep packages * fix install_aduc_deps * Handle errors when download handler plugin symbol missing (#284) * Make DH Factory LoadDownloadHandler noexcept * Make DH Plugin noexcept * throw plugin exception, extract DH extmgr helper * Fix ProcessDownloadHandlerExtensibility docs * Add missing Log_Error for caught PluginException * create erc for each dh export and rmv catch in ADUC_DownloadHandlerPlugin_OnUpdateWorkflowCompleted * Bug 42442896: zlog - incorrect threadproc signature (#287) * Removed log message for retrieving connection information from connection string (#292) * Updated doxygen version (#289) * Updated doxygen version * Changed product name to reflect documentation and removed pre-version * Changed install-deps to clean up after itself (#295) * Updated install-deps to remove old files and cleanup after itself * Fixed script errors * one line fix (#297) * use helper for recursive mkdir (#301) * Try to reconnect to IoT Hub on bad credential or expired SAS token (when using AIS) (#298) * Fix undefined references error in adu-shell (#305) * Took Jeff's suggestion for removing the pthread_cancel calls (#302) * Turn d2c_messaging unit tests into functional tests and skipped by default. (#306) * use TestCaseFixture ptr, not void ptr (#308) * fix zlog file handle leak (#310) * fix zlog file handle leak * set ret=1 upfront and ret 1 when RunAsDesiredUser returns false * rmv last ret=1 straggler * CP: Fix up issues with d2c_messaging. Working on WIOT. Needs to be brought to develop. (#314) Co-authored-by: Jeff Miller <jeffmill@microsoft.com> * Fix build pipeline by fixing cpp-tidy errors (#313) * Fix deadlock in zlog flush deinit (#315) * Fix deadlock in zlog finish flush * rmv flush thread * use zlog_flush_buffer and init zlog_last_flushed to 0 * Fix regression in ADUC_Logging_Init to allow agent to start (#317) * Update cached workfolder when processing replacement workflow (#322) Fixes issue where replacement workflow processing uses the previous workflow's workfolder sandbox that was in the property cache. * Update README.md (#294) * Moved the output of catch from cout to cerr for all CATCH_CONFIG_RUNNER unit tests (#323) * Mark test case "30 retries - httpStatus 401" as functional - takes 30s to run (#325) Co-authored-by: Jeff Miller <jeffmill@microsoft.com> * cherry-pick from wiot-s1 feature branch: GetConnectionInfoFromConnectionString crashes on failure. (#324) (#326) Co-authored-by: Jeff Miller <jeffmill@microsoft.com> * Fix overwrite of contract maj ver in downloaders and comp enumerator (#327) * fix contract majVer overwrite with minVer in content downloaders and content enumerator * fix contract comparison logic * Fixes the E2E Pipeline so all tests pass and scenarios are run (#329) * Removing the cppcheck and clang-tidy to see if that is what is causing the pipeline builds to fail * Making linking changes to see if that fixes the build error * Adding debug lines * Added timeout failures * Added call to set device name when configuring agent through config file - fixes diagnostics * Removed output of the connection string during test * Added input params checks to ConnectionStringUtils_IsNestedEdge to prevent test failures (#330) * Added input params check to prevent bad access * Changed null check to IsNullOrEmpty() * Upgraded patch version (#331) * Fix bug in swupdate-handler v2 example (#333) * Solving merge conflicts main to develop (#338) * Merge 'develop' into 'main' (#243) Fix issue in reboot/restart flow and race condition in D2C messaging util (#242) - Fix an issue for image-based update scenario where the device doesn't reboot after the new image is installed. - Add ADUC_D2C_Message_Type_Device_Properties to avoid a race condition. Note | These changes passed e2e verification internally. * Update issue templates * Update issue templates * Update issue templates Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Esha Shah <92388818+eshashah-msft@users.noreply.github.com> Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Takashi Matsuoka <matsujirushi@live.jp> Co-authored-by: jw-msft <84477130+jw-msft@users.noreply.github.com> Co-authored-by: Pierrick Arsenault <pierrick.arsenault@stello.ca> Co-authored-by: Andrew Brown <59940770+andrewbrownmsft@users.noreply.github.com> Co-authored-by: Jeff Miller <jeffmill@microsoft.com> Co-authored-by: Shiyi Peng <shiyipeng@microsoft.com> Co-authored-by: shiyi-peng <71347127+shiyi-peng@users.noreply.github.com> Co-authored-by: Esha Shah <92388818+eshashah-msft@users.noreply.github.com> Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Esha Shah <92388818+eshashah-msft@users.noreply.github.com> Co-authored-by: Nicholas Hemstreet <62158276+nihemstr@users.noreply.github.com> Co-authored-by: Takashi Matsuoka <matsujirushi@live.jp> Co-authored-by: Pierrick Arsenault <pierrick.arsenault@stello.ca> Co-authored-by: Andrew Brown <59940770+andrewbrownmsft@users.noreply.github.com> Co-authored-by: Jeff Miller <jeffmill@microsoft.com> Co-authored-by: Shiyi Peng <shiyipeng@microsoft.com> Co-authored-by: shiyi-peng <71347127+shiyi-peng@users.noreply.github.com> * Ensure that the step's extendedResultCode is valid when failed to load its desired handler (#343) * fix readdir EOVERFLOW for qemu arm32 on 64bit host (#350) * Fix memleak ADUC_ParseUpdateType (#351) * fix memleak ADUC_ParseUpdateType * clang-format * Do not set glibc _FILE_OFFSET_BITS macro if WIN32 (#354) * Use custom script in CancelApply and Apply step (#347) * Fix simulator handler document bug (#359) * Incrementing Pipeline Version to match agent version (#358) * Merge 'develop' into 'main' (#243) Fix issue in reboot/restart flow and race condition in D2C messaging util (#242) - Fix an issue for image-based update scenario where the device doesn't reboot after the new image is installed. - Add ADUC_D2C_Message_Type_Device_Properties to avoid a race condition. Note | These changes passed e2e verification internally. * Update issue templates * Update issue templates * Update issue templates * Incrementing the version * Removed backtick that keeps following us around Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Esha Shah <92388818+eshashah-msft@users.noreply.github.com> * No alloc FileEntity from workflow_get_update_file (#353) * no alloc of FileEntity from workflow_get_update_file * remove workflow_free_file_entity and nonalloc out for workflow_get_step_detached_manifest_file * Remove the Simulator Platform Layer (#360) * Improve IoTHub_CommunicationManager_Init and DeInit (#363) * SHARED -> MODULE to avoid linking to extensions (#364) MODULE prevents other CMake targets from accidentally linking to the shared libraries as on *nix platforms dlopen is used to load them. * Changed updateType telemetry parsing to match tracing (#361) * Enable pipeline for develop and feature branches and on pr (#365) * enable develop and feature for trigger and pr * remove release/* for now since no longer used post 1.0.x * add unhandled g_connection_status_reason default case (#345) * SWUpdate Handler V2 and Script Handler improvements related to --installed-criteria and --work-folder option (#366) * Incrementing versions from patch 1.0.1 to patch 1.0.2 (#369) * Fix SWUpdate handler V2 device reboot and agent restart issue. (#373) * Set default DO ref to main (#374) * Create how-to-install-deb-pkg-on-rpi.md (#377) * Create how-to-install-deb-pkg-on-rpi.md - Add rpi3 steps for ubuntu 20.04 aarch64 and Debian 10 armhf - Add rpi4 steps for Ubuntu 20.04 aarch64 * Update how-to-install-deb-pkg-on-rpi.md Incorporated feedback. * use python 3.11 in e2e pipelines for perf speedup (#382) * Fix non x64 shellcheck pkg install for RPi4 aarch64 (#380) * While building I was seeing a few tests failing with: (#379) ```text ADUC_ConfigInfo_Init Functional Tests Catch session failed, err=1 ``` I finally debugged into it. Two of our tests have: ```C++ result = Catch::Session().run(argc, argv); if (result != 0) { std::cerr << "Catch session failed, err=" << result << std::endl; } ``` Except that's not correct. When we do `catch_discover_tests (${PROJECT_NAME})` catch runs (e.g.) `config_utils_unit_test --list-test-names-only` and expects the return code to be the number of tests. If there's a non-zero number of tests, we'll get result != 0. Is this output not occurring on Linux, or has no one noticed? In any case, the fix is easy - don't check result here and just return it. Co-authored-by: Jeff Miller <jeffmill@microsoft.com> * Install gcc-10 for Debian 11 bullseye for Rpi4 (#381) * fix: cmake misses some POSITION_INDEPENDENT_CODE settings (#385) Other libraries in this project set POSITION_INDEPENDENT_CODE, ex. workflow_utils, and *depend* on these libraries. Therefore, they need to be position indepent as well. Fixes compilation issues seen first in OpenWRT for device update v0.8.0. Co-authored-by: Francesco Cervigni <f.cervigni@ext.mylight-systems.com> * fix: use ADUC_FILE_GROUP instead of hardcoded "adu" (#388) Co-authored-by: Francesco Cervigni <f.cervigni@ext.mylight-systems.com> * fix: use bool instead of _Bool also in generated code. (#390) All other previous usages of _Bool were already removed in PR #268. These seem to be the last two left. This patch is actually necessary in some compiler scenarios using Musl. Co-authored-by: Francesco Cervigni <f.cervigni@ext.mylight-systems.com> * User/jw msft/rmv do ver (#409) * remove doVer from deviceProperties * rmv target link libraries from agent binary * rmv unused cmake function * rmv straggler in adu core ifc * null terminate after strncpy of jws header (#417) * Add valgrind ctest memcheck, add doc, and fix a ut (#415) * Add valgrind integrated testing via ctest -T memcheck * add valgrind memcheck to quick start and howto build docs * fix memleaks in file_info_utils_ut.cpp * consolidate on calloc_wrapper or cstr_wrapper in UT cpp files * Rename retryTimeout and add downloadTimeoutInMinutes to config file (#416) * Change retryTimeout to maxTimeoutInSeconds * Change extmgr to 8 hours timeout in minutes * Add downloadTimeoutInMinutes to config file * [Test Scenario] Add Agent Startup and Basic Function Verification Test (#425) * Reduce zlog buf BSS loader memory allocation from 512KB to 41KB (#436) * Reduce zlog buffer BSS to 41KB from 512KB to reduce working set * add packer template to build deltaupdate-gen docker image (#432) - Add packer hcl to facilitate building docker image for building DeltaUpdate payloads - Add scripts in scripts dir are run during `packer build .` to get the docker image ready - Add scripts/run.sh for running the container to build the delta from source/target .swu and priv.pem * fix: add missing link to atomic library (#386) With some compiler scenarios, the link is implicit. With others, instead, such link is required to be explicit. One example is OpenWRT 21 + gcc + musl. This change does not affect scenarios where it is implicit. Co-authored-by: Francesco Cervigni <f.cervigni@ext.mylight-systems.com> * Fix FormatFilePathHelper off by one for trailing fwd slash (#437) - Add unit tests for with and without trailing slash in dirPath - Correct to be dirPathSize - 1 * Move extern Default_ExtensionManager_Download_Options into header (#442) * Chg xlog LogError to aduc logging Log_Error in pnp_protocol (#439) * added handling to restart adu in case of "unauthenticated:no network" (#422) * Removed home folder (#449) * Fix Bug: Remove mandatory PLATFORM parameter for DO bootstrap script and DU install-deps (#447) * Fix Bug: IsConnectionInfoValid linking to wrong methods? (#444) * Rmv hardcoded adu-shell path to fix issue #404 (#450) * Implementation of the Ubuntu 20.04 ARM64 End-To-End Test Pipeline (#457) * script file * Templatizing e2e stages * Fixed missing image offer * Stage name changes * Removing other invalid names * Changing scenario path to a parameter verses matrixed value * Fixed incorrect distroname * Added ubuntu 20.04 vm initialization * Fixed yaml issue * yaml * yaml * more yaml nonsense * e2e pipeline vm update * scenario definitions * updating scenario definitions * gah * Hmm * making new stuff * yaml * Fixing bad setup instructions * gah * Running more tests to identify issues in setup script * Moo * yaml * changing build pipeline * Changed targeted pool * Changed targeted pool * Finished evaluating and installing the ubuntu 20.04 arm64 scenario * Responded to PR feedback * fixing a bad commit * Self Upgrade test for Ubuntu 18.04 (#456) * Add the build option "--step-handlers" and related document improvements (#462) * Added AIS provisioning of a module to the e2e flow and tested integration (#468) * initial implementation of ais setup * Raising the privelege on the cp command * Removed non-targeted tests and added code for aziotctl check * Converting to target modules * Removing health check * Bad name * more module nonsense * Fixing Diagnostics * Adding back all the pipelines * fixing spaces * Removing tars * Removing references to Debian 9 in the Readme.md * Formatted the files using autopep8 * skip set ResultCode to success on downloadProc failure (#475) * Changes dependency includes in the python scripts to allow end-to-end pipeline to run (#479) * Moving dependencies so includes work * Fixing includes * Rework the end-to-end test scenario definitions/runners (#469) Co-authored-by: nihemstr <nihemstr@microsoft.com> * remove dbg/trace cmake.exe flags in build.ps1 that crept in while fixing build issues after resolving merge conflicts * Fix Linux Build --------- Co-authored-by: Jeff Miller <jeffmill@microsoft.com> Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Shiyi Peng <shiyipeng@microsoft.com> Co-authored-by: shiyi-peng <71347127+shiyi-peng@users.noreply.github.com> Co-authored-by: Nicholas Hemstreet <62158276+nihemstr@users.noreply.github.com> Co-authored-by: Esha Shah <92388818+eshashah-msft@users.noreply.github.com> Co-authored-by: Takashi Matsuoka <matsujirushi@live.jp> Co-authored-by: Pierrick Arsenault <pierrick.arsenault@stello.ca> Co-authored-by: Andrew Brown <59940770+andrewbrownmsft@users.noreply.github.com> Co-authored-by: JoergZeidler <62105035+JoergZeidler@users.noreply.github.com> Co-authored-by: FC <neonsoftware@users.noreply.github.com> Co-authored-by: Francesco Cervigni <f.cervigni@ext.mylight-systems.com> Co-authored-by: nihemstr <nihemstr@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWUpdate Handler V2
Script Handler