Bug 33471643 simulator + apt - adu_core_interfaces_unit_tests failing #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update our documentation from source of truth main.c * Revision on PR feedback * markdown nit * Revision on suggested nits
* Update how-to-run-agent.md * Update how-to-build-agent-code.md * Update how-to-run-agent.md * Update how-to-run-agent.md * Update how-to-build-agent-code.md * Update how-to-run-agent.md * Update how-to-build-agent-code.md * Add 'adu' and 'do' user setup instruction. Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com> Co-authored-by: Nicholas Hemstreet <62158276+nihemstr@users.noreply.github.com>
* Update how-to-run-agent.md * Update how-to-run-agent.md * Update how-to-run-agent.md * Update how-to-run-agent.md
* Update SUPPORT.md * Update SUPPORT.md
|
The fix looks good! |
|
Closing to reopen with new target branch (changing base branch didn't work out). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADUC_UT_ReportPropertyAsyncValues::set() does memcpy() call into reportedData fixed-array without null-terminating it (g_SendReportedStateValues instance is shared across test methods in adu_core_interface_ut.cpp). For simulator platform layer and microsoft/apt content handler, the test right before the one that fails has a longer reportedData memcpy'ed.
The fix is to put a null-terminator after the memcpy'ed string contents and, for good measure, throw if it would exceed the length of reportedData.