Adding optional timestamp field #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
princjef
reviewed
Feb 8, 2019
| @@ -39,12 +39,22 @@ module.exports = async function (context, device, measurements) { | |||
| throw new StatusError('Invalid format: invalid measurement list.', 400); | |||
| } | |||
|
|
|||
| if (timestamp && isNaN(Date.parse(timestamp))) { | |||
There was a problem hiding this comment.
if someone passes '' or 0 for timestamp will that cause problems?
i'd probably tighten the first part of the check to be safe
Suggested change
| if (timestamp && isNaN(Date.parse(timestamp))) { | |
| if (timestamp != null && isNaN(Date.parse(timestamp))) { |
There was a problem hiding this comment.
ah okay i see the condition below. consider this optional depending on whether you want to tell the user that falsy values won't do anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to optionally specify the date and time of measurements.