Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with LoRaWanNetworkSrvModule #293

Closed
maxstefaniv opened this issue May 13, 2021 · 1 comment · Fixed by #294
Closed

Issue with LoRaWanNetworkSrvModule #293

maxstefaniv opened this issue May 13, 2021 · 1 comment · Fixed by #294
Labels
bug Something isn't working

Comments

@maxstefaniv
Copy link

Got this issue out of nowhere. Saved logs in support_bundle.zip
Restarting edge fixed it.

Expected Behavior

No errors, as I am not doing communication with devices, only receiving telemetry.

Current Behavior

2021-05-13 07:01:51.477 0100DA30: LoRaTools.Mac.MacCommandException: The Mac Command was not well formed, aborting mac command processing
   at LoRaTools.MacCommand..ctor(ReadOnlySpan`1 input) in /build/LoRaEngine/modules/LoRaWanNetworkSrvModule/LoraTools/Mac/MACCommand.cs:line 35
   at LoRaTools.RXParamSetupAnswer..ctor(ReadOnlySpan`1 readOnlySpan) in /build/LoRaEngine/modules/LoRaWanNetworkSrvModule/LoraTools/Mac/RXParamSetupAnswer.cs:line 35
   at LoRaTools.MacCommand.CreateMacCommandFromBytes(String deviceId, ReadOnlyMemory`1 input) in /build/LoRaEngine/modules/LoRaWanNetworkSrvModule/LoraTools/Mac/MACCommand.cs:line 76

Context (Environment)

All data in uploaded .zip

support_bundle.zip
@maxstefaniv maxstefaniv added the bug Something isn't working label May 13, 2021
@Mandur Mandur mentioned this issue May 13, 2021
Merged
Mandur added a commit that referenced this issue May 16, 2021
@Mandur
Fix #293 #292 (#294)
83caedb 
* Upgrade device sdk versions

* Fix Mac issues

* Fix indentation

* Correct test
@Mandur
Copy link
Contributor

Mandur commented May 16, 2021 •
edited

Hello @maxstefaniv

Thank you for raising the issue. I managed to isolate the message triggering the behavior. This is a particular malformed message that doesn't follow the lorawan specs.
Due to a missplaced catch clause in our code, we kept processing the message indefinitely. This is now fixed. We will release a new version in the next days encompassing all these fixes.

Should the problem happen again feel free to reopen the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #293 #292 Azure/iotedge-lorawan-starterkit
2 participants
@Mandur @maxstefaniv