Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert null check on RX2 #280

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Revert null check on RX2 #280

merged 1 commit into from
Jan 7, 2021

Conversation

Mandur
Copy link
Contributor

@Mandur Mandur commented Dec 22, 2020

  • A bug was introduced in dev in Fix missleading logs #260 . Due to one device of the gateway being out use, this was not picked up until it was brought online again.
  • This PR should also make the CI functional again
  • This PR upgrade iot edge to 1.10

@Mandur Mandur added the fullci Run full continuous integration label Dec 22, 2020
@Mandur
Copy link
Contributor Author

Mandur commented Dec 28, 2020

successfull run

C2D Tests: https://dev.azure.com/epicstuff/Azure%20IoT%20Edge%20LoRaWAN%20Starter%20Kit/_build/results?buildId=30723&view=logs&j=7826f347-8899-53d0-eafc-d3fbcaf988d6&t=b3b7d5bb-2197-57f0-8944-1e6878e9d878

OtherTests: https://dev.azure.com/epicstuff/Azure%20IoT%20Edge%20LoRaWAN%20Starter%20Kit/_build/results?buildId=30722&view=logs&j=7826f347-8899-53d0-eafc-d3fbcaf988d6&t=f9a18e38-b3c6-5ba3-031a-47da31209573

fbeltrao
fbeltrao approved these changes Jan 6, 2021
View reviewed changes
Copy link
Collaborator

@fbeltrao fbeltrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Adding nullable reference checks would be interesting to the project.

@Mandur
Copy link
Contributor Author

Mandur commented Jan 6, 2021

Good idea tracked in #281

@Mandur Mandur added fullci Run full continuous integration and removed fullci Run full continuous integration labels Jan 7, 2021
@Mandur Mandur merged commit 3aeacc3 into dev Jan 7, 2021
@Mandur Mandur deleted the mik-dev-fix-dev branch May 16, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeltrao fbeltrao fbeltrao approved these changes

@TechPreacher TechPreacher Awaiting requested review from TechPreacher

@p-schuler p-schuler Awaiting requested review from p-schuler

@ronniesa ronniesa Awaiting requested review from ronniesa

Assignees
No one assigned
Labels
fullci Run full continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mandur @fbeltrao