Shutdown EdgeAgent if ModuleClient gets stuck in ObjectDisposed loop #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myagley
reviewed
May 24, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.IoTHub/ModuleClient.cs
Show resolved
Hide resolved
myagley
approved these changes
May 24, 2019
varunpuranik
added a commit
that referenced
this pull request
May 24, 2019
#1255) * EdgeHub: Add support for a RetryingClient to handle SDK issues (#1239) * Add support for retrying CloudProxy * Add Tests * Add / fix tests * Cleanup and fix test * Fix build * Update RetryingCloudProxyTest.cs * Fix build * Fix RetryCount usage * Fix RetryingCloudProxy loop * Update RetryingCloudProxy.cs * remove env var (#1247) (#1253) * Dispose client on getting an Object Disposed exception (#1211) (#1251) * Kill EA on ObjDispException (#1254) * EdgeHub: Add support for a RetryingClient to handle SDK issues (#1239) * Add support for retrying CloudProxy * Add Tests * Add / fix tests * Cleanup and fix test * Fix build * Update RetryingCloudProxyTest.cs * Fix build * Fix RetryCount usage * Fix RetryingCloudProxy loop * Update RetryingCloudProxy.cs * Fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the SDK can get into a bad state because of this issue - Azure/azure-iot-sdk-csharp#953
This change catches the exception and shuts down the EdgeAgent, so that it can restart and recover.