-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Base Images for Security Vulnerability #4223
Merged
kodiakhq
merged 14 commits into
Azure:release/1.0.10
from
yophilav:yophilav/BaseImageUpdate1.0.5.7_1.0.10
Jan 14, 2021
Merged
Update Base Images for Security Vulnerability #4223
kodiakhq
merged 14 commits into
Azure:release/1.0.10
from
yophilav:yophilav/BaseImageUpdate1.0.5.7_1.0.10
Jan 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `ValidateMetrics` parses [metric readme page](https://github.com/Azure/iotedge/blob/master/doc/BuiltInMetrics.md) to obtain all the metric keys. The test then deploy the system runtime modules and populate its metrics which then are compared against the parsed-document set. There are a handful of not-so-positive metrics that are not being populated if the system modules operated on a happy path during the E2E test. These not-so-positive metrics are currently causing the `ValidateMetrics` to fail since they are not being populated.
…o release/1.0.10
…o release/1.0.10
…o release/1.0.10
…o release/1.0.10
…o release/1.0.10
…o release/1.0.10
…o release/1.0.10
…o release/1.0.10
…o release/1.0.10
yophilav
requested review from
ancaantochi,
and-rewsmith,
dylanbronson and
damonbarry
January 13, 2021 22:41
damonbarry
approved these changes
Jan 14, 2021
dylanbronson
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out pr and didn't find old images. LGTM
Thank you for the approval. I'm waiting for the publication of WinIoT ARM32 to be done before I merge the PR. |
yophilav
added a commit
to yophilav/iotedge
that referenced
this pull request
Jan 14, 2021
Updating Base Images for Security Vulnerability: https://msrc.microsoft.com/update-guide/vulnerability/CVE-2021-1723 List of Update Base Images: - Linux AMD64 : 3.1.4-alpine3.11 --> 3.1.11-alpine3.12 - Linux ARM32 & ARM64 : 3.1.10-bionic-arm* --> 3.1.11-bionic-arm* - Windows AMD64 : 3.1.10-nanoserver-1809 --> 3.1.11-nanoserver-1809 - Windows ARM32 : nanoserver:1809-arm32v7 (latest) Publishing ARM Base Images: 1.0.5.7-linux-arm* Note to Reviewer: Please feel free to pull the branch down to your local machine and use your favorite editor's regex to make sure the base images are updated correctly. (I wish there is an easier way to do this).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 14, 2021
Updating Base Images for Security Vulnerability: https://msrc.microsoft.com/update-guide/vulnerability/CVE-2021-1723 List of Update Base Images: - Linux AMD64 : 3.1.4-alpine3.11 --> 3.1.11-alpine3.12 - Linux ARM32 & ARM64 : 3.1.10-bionic-arm* --> 3.1.11-bionic-arm* - Windows AMD64 : 3.1.10-nanoserver-1809 --> 3.1.11-nanoserver-1809 - Windows ARM32 : nanoserver:1809-arm32v7 (latest) Publishing ARM Base Images: 1.0.5.7-linux-arm* Note to Reviewer: Please feel free to pull the branch down to your local machine and use your favorite editor's regex to make sure the base images are updated correctly. (I wish there is an easier way to do this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Base Images for Security Vulnerability:
https://msrc.microsoft.com/update-guide/vulnerability/CVE-2021-1723
List of Update Base Images:
Publishing ARM Base Images:
1.0.5.7-linux-arm*
Note to Reviewer:
Please feel free to pull the branch down to your local machine and use your favorite editor's regex to make sure the base images are updated correctly. (I wish there is an easier way to do this).