[mqtt] upgrade mqtt to tokio1 release #4830
Conversation
| @@ -16,7 +16,7 @@ where | |||
| IoS: super::IoSource, | |||
| { | |||
| BeginBackOff, | |||
| EndBackOff(tokio::time::Delay), | |||
| EndBackOff(std::pin::Pin<Box<tokio::time::Sleep>>), | |||
There was a problem hiding this comment.
It would be nice to avoid the allocation by changing the client code to support State: !Unpin (which would probably include making Client: !Unpin). And for State itself, the pin-project crate makes it easier to access !Unpin data of !Unpin enums.
There was a problem hiding this comment.
Yeah, I did one pass on using pin-project but got lost. I'm planning to do another pass again soon.
There was a problem hiding this comment.
Yes, it gets hairy when you have to re-assign self to be a different variant, and especially hairy when you have to re-assign self to be a different variant but containing some of the data from the current variant.
|
Could these changes be tested against a longhaul or some sort of test setup that runs for a time period of several hours? Given the huge leap in Tokio and nuanced changes in some places, maybe some bake time would be helpful? Your call :) |
| @@ -1,4 +1,4 @@ | |||
| //! `tokio::time::delay_for` and `tokio::time::delay_until` has a bug that | |||
| //! `tokio::time::sleep` and `tokio::time::delay_until` has a bug that | |||
There was a problem hiding this comment.
is this still true?
There was a problem hiding this comment.
good catch! seems panic was fixed recently. but still
The maximum duration for a sleep is 68719476734 milliseconds (approximately 2.2 years).
source: https://docs.rs/tokio/1.5.0/tokio/time/fn.sleep.html
There was a problem hiding this comment.
2.2y is not enough for us?
There was a problem hiding this comment.
for test purposes I made the one for 10y and it caused some problems for me previously.
Upgrade mqtt to a new `tokio v1.x` ecosystem. There are some known issues which will be addressed in upcoming PRs: 1. tracing log formatter is default 2. `mqtt3::Client` has a timer pinned on heap instead of pinned on stack 3. `percent_encoding` is outdated 4. `mockall` is outdated
Upgrade mqtt to a new `tokio v1.x` ecosystem. There are some known issues which will be addressed in upcoming PRs: 1. tracing log formatter is default 2. `mqtt3::Client` has a timer pinned on heap instead of pinned on stack 3. `percent_encoding` is outdated 4. `mockall` is outdated
Upgrade mqtt to a new
tokio v1.xecosystem. There are some known issues which will be addressed in upcoming PRs:mqtt3::Clienthas a timer pinned on heap instead of pinned on stackpercent_encodingis outdatedmockallis outdated