Migrate Azure Monitor project to our repository. #4877
Conversation
pmzara
commented
Apr 21, 2021
pmzara
commented
- Moving Azure Monitor source code to our repository.
- Integrate into appropriate pipelines
edge-modules/azure-monitor/docker/linux/arm32v7/base/Dockerfile
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Mostly the same review as last time, but I caught a few more things.
I think we should:
- revert the change that removes the additionalTags logic
- address the comments
- run the build images pipeline and build images release pipeline to verify nothing is broken
After that it is safe to merge
|
@pmzara Let me know if you need help running the build image and build image release pipelines to confirm these changes won't break the builds. |
|
Images build running off latest changes here: Discussed with Pedro and he is testing the release images build to confirm it still works. |
There was a problem hiding this comment.
Recommend waiting for the images release practice build to succeed before merge, but looks good to me! @damonbarry Venkat just pinged me about the additionalTags logic. Should we have a PR following this one to remove the additionalTags?
- Moving Azure Monitor source code to our repository. - Integrate into appropriate pipelines
Includes 1.1.2 and all commits as of the time of this PR: Add EFLOW Job to Long Haul Test Pipeline (#4571) Test Dashboard: Allow longhaul / connectivity pipelines to show with new dashboard queries (#4695) Update ARM Base Image Security Patch (#4808) Prepare for Release 1.1.2 Longhaul: Update snitcher linux images (#4843) Fix ValidateMetrics on ARM32 (#4864) Update C SDK submodules to 2020-12-09. (#4867) Fix Windows construction of identity cert PKCS#12 blob to not leak keys to disk. (#4854) Delete all containers after reprovision (#4833) Remove Debian 8 build/package logic (#4876) Bump serde-yaml version to 0.8 (#4860) Allow release image pipeline to use a custom CR (#3507) (#4882) Migrate Azure Monitor project to our repository. (#4877) Metrics transform option (#4893)
