Adds SharedAccessSignature to repo with fix for vulnerability (#4943) #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4943) This adds a subset of the code from https://github.com/Azure/azure-iot-sdk-csharp for SharedAccessSignature directly into our repo. This will also need to be cherry-picked into 1.1 and 1.2. Todo: - [x] Create UTs (UT=unit test) around this code, as there seem to be some tests that use parts of SharedAccessSignature but nothing completely dedicated - [x] See if more code can be trimmed out that is not being used, just removed things without any references for first pass - [x] if only using one supported .net then can maybe remove some other code here
nyanzebra
requested review from
vadim-kovalyov,
varunpuranik,
ancaantochi and
vipeller
vadim-kovalyov
approved these changes
May 10, 2021
darobs
pushed a commit
to darobs/iotedge
that referenced
this pull request
May 26, 2021
…4943) (Azure#4967) This is a cherry-pick of Azure#4943 This adds a subset of the code from https://github.com/Azure/azure-iot-sdk-csharp for SharedAccessSignature directly into our repo. This will also need to be cherry-picked into 1.1 and 1.2. Todo: - [x] Create UTs (UT=unit test) around this code, as there seem to be some tests that use parts of SharedAccessSignature but nothing completely dedicated - [x] See if more code can be trimmed out that is not being used, just removed things without any references for first pass - [x] if only using one supported .net then can maybe remove some other code here
darobs
added a commit
that referenced
this pull request
May 26, 2021
* Update the KeyVault for Test pipelines (#4937) * Metrics Collector: Remove test-specific additional tags logic (#4950) * Metrics Collector: Add gzip compression in the iot message scenario (#4955) * E2E: Metrics Collector Smoke Test (#4945) * Metrics Collector: Cleanup startup logging (#4953) * Metrics Collector: Update product info and message id (#4962) * Metrics Collector: Rename HubResourceId -> ResourceId (#4956) * Adds SharedAccessSignature to repo with fix for vulnerability (#4943) (#4967) * Metrics Collector: Release and publish pipelines (#4969) * Close AMQP connection explicitly when no more links (removing links kept tcp level connection) (#4984) * Update `GetModuleLogs` method when `tail + since + until` options are provided (#4987) * Introduce `Timestamps` Option via mgmt.sock (#4988) * Cherry-pick to Release/1.1: Fix edgehub queue len metric (#4952) (#4990) * Update Base Images for Security Patch (#4994) * Update v1.1 YAML pipelines to 1ES-hosted agents (#4844) * Fix potential instability in iotedged after UploadSupportBundle fails (#4942) * Rename end-to-end test log artifacts (#5006) * Merge Prometheus parser fix. (#5007) * Prepare for Release 1.1.3 (#5008) * Fixing diagnostics image for 1.1 (#5018) * Prepare for Release1.1.3 (part 2) (#5020) * Remove PII from log. (#5022) Co-authored-by: yophilav <54859653+yophilav@users.noreply.github.com> Co-authored-by: Andrew Smith <als5ev@virginia.edu> Co-authored-by: Robert T Jang <robbaldwin95@gmail.com> Co-authored-by: vipeller <51135538+vipeller@users.noreply.github.com> Co-authored-by: Damon Barry <damonbarry@users.noreply.github.com> Co-authored-by: Pedro Marcelo Zara <pmzara@hotmail.com> Co-authored-by: dylanbronson <55515325+dylanbronson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #4943
This adds a subset of the code from https://github.com/Azure/azure-iot-sdk-csharp for SharedAccessSignature directly into our repo. This will also need to be cherry-picked into 1.1 and 1.2.
Todo: