Use Docker Timestamp When Log Timestamp is not Available in JSON log. #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damonbarry
previously approved these changes
May 13, 2021
…s://github.com/yophilav/iotedge into yophilav/GetModuleLogsIssue4_dotnet_backup_1.2
damonbarry
approved these changes
Jun 17, 2021
yophilav
added a commit
to yophilav/iotedge
that referenced
this pull request
Jun 25, 2021
…Azure#4981) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires Azure#4970
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
…4981) (#5167) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires #4970
yophilav
added a commit
that referenced
this pull request
Jun 29, 2021
…#5173) Derived from #4981 Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires #5172
nyanzebra
pushed a commit
to nyanzebra/iotedge
that referenced
this pull request
Jul 2, 2021
…zure#4981) (Azure#5167) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires Azure#4970
ggjjj
pushed a commit
to ggjjj/iotedge
that referenced
this pull request
Jul 22, 2021
…zure#4981) (Azure#5167) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires Azure#4970
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
…zure#4981) (Azure#5167) Context: It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API. Solution: This PR issues `timestamps` from edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal. Note: This feature requires Azure#4970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
It generates the attached file, if a module does not use the prescribed logging format (which most module do not), the timestamp is 0. This makes the logs not very useful. The timestamp irrespective of logging format is actually available from Docker log API.
Solution:
This PR issues
timestampsfrom edgeAgent via mgmt.sock to prepending the returning log with timestamp. edgeAgent then parse the timestamp & return the value in json format to portal.Note:
This feature requires #4970