Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate OS image update for AMD64 #5187

Conversation

yophilav
Copy link
Contributor

@yophilav yophilav commented Jun 29, 2021

Automate OS image update for AMD64

Copy link
Contributor

@and-rewsmith and-rewsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume PR title should be for AMD64.

tools/snitch/snitcher/docker/windows/amd64/Dockerfile Outdated Show resolved Hide resolved
tools/BaseImageUpdate/baseImage.ps1 Show resolved Hide resolved
#>
[Parameter(Mandatory=$false)]
[Object[]]
$FileLocale
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what case is this param needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I was thinking that I should have a function that calls both Update-ARM-BaseImages and Update-AMD64-BaseImages. This param will allow traversing the folder structure twice. I suppose I can create that function now both of the sub functions are ready.

# \iotedge\edge-modules\functions\samples\docker\linux\amd64\Dockerfile ________(Azure Function)
# \iotedge\tools\snitch\prep-mail\docker\linux\amd64\Dockerfile ________________(Deprecating)
# \iotedge\tools\snitch\snitcher\docker\linux\amd64\Dockerfile _________________(Deprecating)
# \iotedge\edgelet\iotedged\docker\linux\amd64\Dockerfile ______________________(debian10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool formatting!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

and-rewsmith
and-rewsmith previously approved these changes Jun 29, 2021
@yophilav yophilav changed the title Automate OS image update for ARM64 Automate OS image update for AMD64 Jul 2, 2021
@yophilav yophilav merged commit 720e976 into Azure:release/1.1 Jul 7, 2021
yophilav added a commit to yophilav/iotedge that referenced this pull request Jul 7, 2021
Automate OS image update for AMD64
yophilav added a commit to yophilav/iotedge that referenced this pull request Jul 7, 2021
Automate OS image update for AMD64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants