[k8s] update k8s client. #5210
Merged
[k8s] update k8s client. #5210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanzebra
reviewed
Jul 12, 2021
| @@ -84,7 +84,7 @@ public async void ReadDeploymentConfigFromSecret() | |||
| }; | |||
|
|
|||
| var client = new Mock<IKubernetes>(MockBehavior.Strict); | |||
| client.Setup(c => c.ReadNamespacedSecretWithHttpMessagesAsync(DefaultSecretName, DefaultNamespace, It.IsAny<bool?>(), It.IsAny<bool?>(), null, null, It.IsAny<CancellationToken>())) | |||
| client.Setup(c => c.ReadNamespacedSecretWithHttpMessagesAsync(DefaultSecretName, DefaultNamespace, It.IsAny<string>(), null, It.IsAny<CancellationToken>())) | |||
There was a problem hiding this comment.
nit: since these are already being changed, should we put a named param for the null? Just to increase readability? Your call, not familiar with what the standard here is for our codebase, but just an idea :)
There was a problem hiding this comment.
I wonder if Moq will allow me to label these like name:DefaultSecretName or if I should just comment them like I did elsewhere.
There was a problem hiding this comment.
The quick attempt to label parameters gave me a compilation error, so I went with commenting the parameters like I did in the other files.
nyanzebra
approved these changes
Jul 13, 2021
darobs
added a commit
that referenced
this pull request
Jul 14, 2021
* Update to latest k8s client to address vulnerabilities in dependencies.
darobs
added a commit
that referenced
this pull request
Aug 3, 2021
darobs
added a commit
that referenced
this pull request
Aug 3, 2021
darobs
added a commit
to darobs/iotedge
that referenced
this pull request
Sep 9, 2021
* Update to latest k8s client to address vulnerabilities in dependencies. (This project is not used in master, but it still referenced, so this needed to be updated to satisfy component governance.)
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
… (Azure#5483) * Update to latest k8s client to address vulnerabilities in dependencies. (This project is not used in master, but it still referenced, so this needed to be updated to satisfy component governance.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest k8s client to address vulnerabilities in dependencies.