Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default E2E test artifacts #5260

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

yophilav
Copy link
Contributor

Update default E2E test artifacts for release/1.1 branch.

huguesBouvier
huguesBouvier previously approved these changes Jul 16, 2021
@@ -7,14 +7,12 @@ resources:
source: 'Azure-IoT-Edge-Core Build Images'
trigger:
branches:
- master
- release/*
- release/1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master and 1.2 are configured like this:
https://github.com/Azure/iotedge/blob/master/builds/e2e/e2e.yaml#L12

I think what you actually want to change is this, not the trigger:
https://github.com/Azure/iotedge/blob/master/builds/e2e/e2e.yaml#L11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I assume you're trying to change which artifacts are chosen by default in a manual or scheduled run of the pipeline (as opposed to a run triggered by commits landing in a branch)?

@kodiakhq kodiakhq bot merged commit 5511d64 into Azure:release/1.1 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants